Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-127705: better double free message.#130785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commentedMar 3, 2025
edited by bedevere-appbot
Loading

Adds aPy_STACKREF_CLOSE_DEBUG #definable option to track closed stack refs. This gives us precise locations for the the initial close and subsequent use or close.

For example, there is a use-after-free in BINARY_OP_INPLACE_ADD_UNICODE (which this PR does not fix)

On main the error message is this:

Fatal Python error: _Py_stackref_record_borrow:   Invalid StackRef with ID 15618638

With this PR it looks like this:

 Fatal Python error: _Py_stackref_record_borrow:    Borrow of closed ref ID 15609203 at Python/generated_cases.c.h:59.   Referred to instance of str at 0x55a2b6c5ff10.    Closed at Python/generated_cases.c.h:344

(I've reformatted the messages for clarity, but the content is unchanged):

@markshannonmarkshannon merged commit78d50e9 intopython:mainMar 5, 2025
49 checks passed
@markshannonmarkshannon deleted the better-double-free-message branchMarch 5, 2025 14:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-SpinnerFidget-Spinner is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markshannon@iritkatriel

[8]ページ先頭

©2009-2025 Movatter.jp