Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-128942: make arraymodule.c free-thread safe (lock-free)#130771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tom-pytel wants to merge43 commits intopython:main
base:main
Choose a base branch
Loading
fromtom-pytel:fix-issue-128942-lockfree
Open
Changes from1 commit
Commits
Show all changes
43 commits
Select commitHold shift + click to select a range
f54c5fc
slow arraymodule
tom-pytelMar 1, 2025
4c71f00
lockfree read and write single element
tom-pytelMar 2, 2025
512c4c7
📜🤖 Added by blurb_it.
blurb-it[bot]Mar 2, 2025
060100f
ensure_shared_on_resize() in one more place
tom-pytelMar 2, 2025
d0b17c6
fix stupid direct return out of critical section
tom-pytelMar 3, 2025
c17b787
requested changes
tom-pytelMar 3, 2025
4fd8383
downgrade to _Py_atomic_load_ptr_relaxed in missed place
tom-pytelMar 3, 2025
d00f2b7
arraymodule linked statically
tom-pytelMar 4, 2025
a3e6004
cleanups
tom-pytelMar 5, 2025
fb6212a
test and tsan stuff
tom-pytelMar 5, 2025
04a8f9d
getters and setters using atomics
tom-pytelMar 5, 2025
01423fd
fix 2 byte wchar_t
tom-pytelMar 6, 2025
99331dd
remove debug printf
tom-pytelMar 6, 2025
07c98cc
just a hunch...
tom-pytelMar 6, 2025
cf3bbbb
atomic "memcpy"
tom-pytelMar 6, 2025
51135a4
misc
tom-pytelMar 7, 2025
fff827e
use proper type FT_ macros
tom-pytelMar 8, 2025
12f0ff6
atomic aggregate _Py_atomic_source_memcpy_relaxed()
tom-pytelMar 10, 2025
1a6b8df
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMar 11, 2025
94ef417
remove atomic memcpy
tom-pytelMar 11, 2025
0056412
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMar 11, 2025
1431784
regen clinic
tom-pytelMar 11, 2025
460d3d7
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMar 11, 2025
409239c
requested changes
tom-pytelMar 15, 2025
a6f17c9
more requested changes
tom-pytelMar 17, 2025
b5d219e
__declspec(align(8)) for Windows
tom-pytelMar 17, 2025
2c82071
shut up check-c-globals
tom-pytelMar 17, 2025
1ba50e9
alignment changes
tom-pytelMar 20, 2025
576aebf
MS_WINDOWS -> _MSC_VER
tom-pytelMar 20, 2025
4dd0954
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMar 20, 2025
d4e5313
#include "pycore_gc.h", something moved
tom-pytelMar 20, 2025
48eabe3
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMar 25, 2025
c056b13
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMar 25, 2025
affae8e
remove NULL check in arraydata_free()
tom-pytelMar 25, 2025
689c7a3
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMar 31, 2025
3e2f8cd
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelApr 4, 2025
7286fed
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelApr 14, 2025
6550906
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelApr 23, 2025
5b35203
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMay 2, 2025
15d92ca
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMay 5, 2025
2e7132e
change to use new _Py_ALIGN_AS() macro
tom-pytelMay 5, 2025
06f86cf
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMay 8, 2025
d29c208
Merge branch 'main' into fix-issue-128942-lockfree
tom-pytelMay 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
MS_WINDOWS -> _MSC_VER
  • Loading branch information
@tom-pytel
tom-pytel committedMar 20, 2025
commit576aebf4ba5ed9dbae32c66d7df3305f1df950e8
2 changes: 1 addition & 1 deletionModules/arraymodule.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,7 +42,7 @@
int is_signed;
};

#ifdefMS_WINDOWS
#ifdef_MSC_VER
#define Py_ALIGN_AS(x) __declspec(align(x))
#else
#define Py_ALIGN_AS(x) _Alignas(x)
Expand DownExpand Up@@ -233,9 +233,9 @@
// Ensure that the array is freed using QSBR if we are not the
// owning thread.
if (!_Py_IsOwnedByCurrentThread((PyObject *)self) &&
!_PyObject_GC_IS_SHARED(self))

Check failure on line 236 in Modules/arraymodule.c

View workflow job for this annotation

GitHub Actions/ Ubuntu (free-threading) / build and test (ubuntu-24.04)

implicit declaration of function ‘_PyObject_GC_IS_SHARED’ [-Werror=implicit-function-declaration]

Check failure on line 236 in Modules/arraymodule.c

View workflow job for this annotation

GitHub Actions/ Ubuntu (free-threading) / build and test (ubuntu-24.04-arm)

implicit declaration of function ‘_PyObject_GC_IS_SHARED’ [-Werror=implicit-function-declaration]

Check warning on line 236 in Modules/arraymodule.c

View workflow job for this annotation

GitHub Actions/ Windows (free-threading) / build (arm64)

'_PyObject_GC_IS_SHARED' undefined; assuming extern returning int [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check warning on line 236 in Modules/arraymodule.c

View workflow job for this annotation

GitHub Actions/ Windows (free-threading) / build and test (x64)

'_PyObject_GC_IS_SHARED' undefined; assuming extern returning int [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
{
_PyObject_GC_SET_SHARED(self);

Check failure on line 238 in Modules/arraymodule.c

View workflow job for this annotation

GitHub Actions/ Ubuntu (free-threading) / build and test (ubuntu-24.04)

implicit declaration of function ‘_PyObject_GC_SET_SHARED’ [-Werror=implicit-function-declaration]

Check failure on line 238 in Modules/arraymodule.c

View workflow job for this annotation

GitHub Actions/ Ubuntu (free-threading) / build and test (ubuntu-24.04-arm)

implicit declaration of function ‘_PyObject_GC_SET_SHARED’ [-Werror=implicit-function-declaration]

Check warning on line 238 in Modules/arraymodule.c

View workflow job for this annotation

GitHub Actions/ Windows (free-threading) / build (arm64)

'_PyObject_GC_SET_SHARED' undefined; assuming extern returning int [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

Check warning on line 238 in Modules/arraymodule.c

View workflow job for this annotation

GitHub Actions/ Windows (free-threading) / build and test (x64)

'_PyObject_GC_SET_SHARED' undefined; assuming extern returning int [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]
}
#endif

Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp