Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-128520: Mergepathlib._abc intopathlib.types#130747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
barneygale merged 1 commit intopython:mainfrombarneygale:gh-128520-module-move
Mar 3, 2025

Conversation

barneygale
Copy link
Contributor

@barneygalebarneygale commentedMar 1, 2025•
edited
Loading

There used to be a meaningful distinction between these modules:pathlib importedpathlib._abc but notpathlib.types, and so zero-cost type annotations could only be added to the latter. This is no longer the case (neither module is imported), so we move the ABCs as follows:

  • pathlib._abc.JoinablePath -->pathlib.types._JoinablePath
  • pathlib._abc.ReadablePath -->pathlib.types._ReadablePath
  • pathlib._abc.WritablePath -->pathlib.types._WritablePath

Thepathlib._abc module is deleted.

There used to be a meaningful distinction between these modules: `pathlib`imported `pathlib._abc` but not `pathlib.types`. This is no longer thecase (neither module is imported), so we move the ABCs as follows:- `pathlib._abc.JoinablePath` --> `pathlib.types._JoinablePath`- `pathlib._abc.ReadablePath` --> `pathlib.types._ReadablePath`- `pathlib._abc.WritablePath` --> `pathlib.types._WritablePath`
@barneygalebarneygale merged commitd0eb01c intopython:mainMar 3, 2025
44 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu Shared 3.x (tier-1) has failed when building commitd0eb01c.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/10011) and take a look at the build logs.
  4. Check if the failure is related to this commit (d0eb01c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/10011

Failed tests:

  • test.test_concurrent_futures.test_process_pool

Failed subtests:

  • test_force_shutdown_workers - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_force_shutdown_workers
  • test_force_shutdown_workers - test.test_concurrent_futures.test_process_pool.ProcessPoolForkProcessPoolExecutorTest.test_force_shutdown_workers

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_importlib/metadata/fixtures.py", line391, in_inner    func(self,**args)~~~~^^^^^^^^^^^^^^  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures/test_process_pool.py", line279, intest_force_shutdown_workersself.assertEqual(worker_process.exitcode,-signal.SIGTERM)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:255 != -15Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_importlib/metadata/fixtures.py", line391, in_inner    func(self,**args)~~~~^^^^^^^^^^^^^^  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_concurrent_futures/test_process_pool.py", line281, intest_force_shutdown_workersself.assertEqual(worker_process.exitcode,-signal.SIGKILL)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:255 != -9

seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…0747)There used to be a meaningful distinction between these modules: `pathlib`imported `pathlib._abc` but not `pathlib.types`. This is no longer thecase (neither module is imported), so we move the ABCs as follows:- `pathlib._abc.JoinablePath` --> `pathlib.types._JoinablePath`- `pathlib._abc.ReadablePath` --> `pathlib.types._ReadablePath`- `pathlib._abc.WritablePath` --> `pathlib.types._WritablePath`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@barneygale@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp