Also request@serhiy-storchaka

Thanks! Could you also add tests that cover the 4 missing lines?

First line: I would consider fine as it just breaks on the first run

Second line: not sure why it’s yellow

third line: Is it necessary?

fourth line: returns before reaching c

I don’t see any reason to run a test with just c

It's important to test these if we're going to touch the behaviour offind later. The function is quite complex and I wouldn't feel confident modifying it w/o proper test coverage. Since we're going through the trouble to write tests for it, let's make sure it's all covered :)

First line: I would consider fine as it just breaks on the first run

The loop always breaks which means you never test the case wherelanguages == [].

Second line: not sure why it’s yellow

The condition was alwaysTrue in tests

100% (of find)

Can you double-check that we have full coverage? Otherwise I think it's good :)

@tomasr8

Looks pretty green to me :-)

🤖 New build scheduled with the buildbot fleet by@encukou for commit9afb57d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130691%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

Do we want to backport them or not by the way?

I think so, similar test PRs were also previously backported.

Thanks@StanFromIreland for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

Thanks@StanFromIreland for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

GH-132083 is a backport of this pull request to the3.12 branch.

GH-132084 is a backport of this pull request to the3.13 branch.