Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130655: Increase test coverage ofgettext._expand_lang#130656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 1 commit intopython:mainfromtomasr8:gettext-expand-lang
Feb 28, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedFeb 27, 2025•
edited by bedevere-appbot
Loading

This will help with properly testinggettext.find which calls_expand_lang.

With these tests, the function is fully covered:

obrazek

@tomasr8tomasr8 added testsTests in the Lib/test dir skip news needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsFeb 27, 2025
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

tomasr8 reacted with rocket emoji
@serhiy-storchakaserhiy-storchaka merged commit24c52cb intopython:mainFeb 28, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks@tomasr8 for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 28, 2025
…thonGH-130656)(cherry picked from commit24c52cb)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-130671 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelFeb 28, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 28, 2025
…thonGH-130656)(cherry picked from commit24c52cb)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-130672 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 28, 2025
@tomasr8tomasr8 deleted the gettext-expand-lang branchFebruary 28, 2025 08:44
serhiy-storchaka pushed a commit that referenced this pull requestFeb 28, 2025
…H-130656) (GH-130672)(cherry picked from commit24c52cb)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull requestFeb 28, 2025
…H-130656) (GH-130671)(cherry picked from commit24c52cb)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@tomasr8@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp