Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130587: Add hand-written docs for non-OP tokens#130588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 15 commits intopython:mainfromencukou:token-docs
Mar 19, 2025

Conversation

encukou
Copy link
Member

@encukouencukou commentedFeb 26, 2025•
edited by github-actionsbot
Loading

  • Add hand-written docs for non-OP tokens

  • Make the automation (generate_token.py)check that the hand-written docs are present, and only generate docs for the OP tokens

  • Switch tolist-table for the OP tokens, to make their docs more compact

  • AddENDMARKER to the grammar docs where it appears (toplevel components)

  • Add forgottenversionchanged entry forEXCLAMATION

  • Remove docs forNT_OFFSET

📚 Documentation preview 📚:https://cpython-previews--130588.org.readthedocs.build/

@encukou
Copy link
MemberAuthor

@encukou
Copy link
MemberAuthor

@lysnikolaou, does this look reasonable to you?

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks like a good improvement to me! Thanks@encukou!

I've left some inline comments regarding some specifics in the docs.

encukou reacted with heart emoji
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@encukou
Copy link
MemberAuthor

Thank you for the reviews! I addressed some; I'll continue next week.

AA-Turner reacted with thumbs up emoji

Comment on lines +22 to +25
Note that a token's value may depend on tokenizer options. For example, a
``"+"`` token may be reported as either :data:`PLUS` or :data:`OP`, or
a ``"match"`` token may be either :data:`NAME` or :data:`SOFT_KEYWORD`.

Copy link
MemberAuthor

@encukouencukouMar 5, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I added this note to clarify the “fuzziness” of these categories.

AA-Turner reacted with thumbs up emoji
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@encukouencukou merged commit4bced29 intopython:mainMar 19, 2025
39 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMar 19, 2025
@encukouencukou deleted the token-docs branchMarch 19, 2025 15:42
@encukouencukou added the needs backport to 3.13bugs and security fixes labelMar 19, 2025
@miss-islington-app
Copy link

Thanks@encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@encukou, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 4bced29a74c4dbcf310a47e8202292aaa39b617b 3.13

@bedevere-app
Copy link

GH-131465 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMar 19, 2025
encukou added a commit to encukou/cpython that referenced this pull requestMar 19, 2025
…0588)Co-authored-by: Blaise Pabon <blaise@gmail.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>(cherry picked from commit4bced29)
encukou added a commit to encukou/cpython that referenced this pull requestMar 19, 2025
…onGH-130588)(cherry picked from commit4bced29)Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Blaise Pabon <blaise@gmail.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
encukou added a commit that referenced this pull requestMar 24, 2025
…GH-131465)Co-authored-by: Blaise Pabon <blaise@gmail.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…0588)Co-authored-by: Blaise Pabon <blaise@gmail.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

@lysnikolaoulysnikolaoulysnikolaou left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

@encukouencukou

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@encukou@AA-Turner@lysnikolaou@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp