Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.13] gh-130163: Fix crashes related to PySys_GetObject() (GH-130503)#130556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 2 commits intopython:3.13fromserhiy-storchaka:backport-0ef4ffe-3.13Feb 25, 2025
Merged
[3.13] gh-130163: Fix crashes related to PySys_GetObject() (GH-130503)#130556
serhiy-storchaka merged 2 commits intopython:3.13fromserhiy-storchaka:backport-0ef4ffe-3.13Feb 25, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…honGH-130503)The use of PySys_GetObject() and _PySys_GetAttr(), which return a borrowedreference, has been replaced by using one of the following functions, whichreturn a strong reference and distinguish a missing attribute from an error:_PySys_GetOptionalAttr(), _PySys_GetOptionalAttrString(),_PySys_GetRequiredAttr(), and _PySys_GetRequiredAttrString().(cherry picked from commit0ef4ffe)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
7c1b76f intopython:3.13 37 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry,@serhiy-storchaka, I could not cleanly backport this to |
This change introduced reference leaks in the 3.13 branch. Example: cc@encukou |
Example of buildbot failure, Fedora Stable (x86):https://buildbot.python.org/#/builders/1471/builds/551 Failed tests:
|
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestFeb 26, 2025
…honGH-130503) (pythonGH-130556)The use of PySys_GetObject() and _PySys_GetAttr(), which return a borrowedreference, has been replaced by using one of the following functions, whichreturn a strong reference and distinguish a missing attribute from an error:_PySys_GetOptionalAttr(), _PySys_GetOptionalAttrString(),_PySys_GetRequiredAttr(), and _PySys_GetRequiredAttrString().(cherry picked from commit0ef4ffe)(cherry picked from commit7c1b76f)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-130576 is a backport of this pull request to the3.12 branch. |
serhiy-storchaka added a commit that referenced this pull requestFeb 26, 2025
GH-130556) (GH-130576)The use of PySys_GetObject() and _PySys_GetAttr(), which return a borrowedreference, has been replaced by using one of the following functions, whichreturn a strong reference and distinguish a missing attribute from an error:_PySys_GetOptionalAttr(), _PySys_GetOptionalAttrString(),_PySys_GetRequiredAttr(), and _PySys_GetRequiredAttrString().(cherry picked from commit0ef4ffe)(cherry picked from commit7c1b76f)(cherry picked from commit2ab7e11)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The use of PySys_GetObject() and _PySys_GetAttr(), which return a borrowed reference, has been replaced by using one of the following functions, which return a strong reference and distinguish a missing attribute from an error: _PySys_GetOptionalAttr(), _PySys_GetOptionalAttrString(), _PySys_GetRequiredAttr(), and _PySys_GetRequiredAttrString(). (cherry picked from commit0ef4ffe)
printand concurrently modifyingsys.stdout#130163