Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-128540: lookup default webbrowser on Windows#130538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
minrk wants to merge1 commit intopython:mainChoose a base branch fromminrk:default-browser-windows
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
lookup default browsers via `UrlAssociations\https\UserChoice` if protocol is not http/httpsensures browser is opened for e.g. file:// URLs
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
lookup default browsers via
UrlAssociations\https\UserChoiceif protocol is not http/https. ensureswebbrowser.openlaunches a web browser on Windows, even for URLs that are not http[s]. Only does the lookup for non-http URLs, limiting the impact of the change.ensures browser is opened for e.g.
file://URLs, wherestartfileopens file by association. Launching custom protocols explicitly goes through the browser instead of throughstartfile. The end result isusually the same, after a prompt, unless the browser has explicit support/configuration for the protocol. Alternative: only lookup forfile://instead ofnothttp[s]://.Added extremely basic test exercise, the registry lookups are not actually covered, but I have tested them by hand. I'm not sure how to write good tests for the registry stuff.
Addressesgh-128540 on Windows only.
Open questions:
os.startfile("ssh://some-host")might start putty or something, whereas this explicitly launches the browser (which would in turn typically prompt "launch external application PuTTy..?"). Behavior for custom URLs is previously undefined and inconsistent, but after this PR, it consistently launches a webbrowser if it can, but remainsundefined.opencommand-line lack%1and still be valid (e.g. withappend)? I can't find a spec for this, so it would be good to know. I've gone with the most conservative, which is to assume it doesn't work if%1is not present, falling back on previousos.startfilein that case.Links: