Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128540: lookup default webbrowser on macOS#130535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ned-deily merged 3 commits intopython:mainfromminrk:default-browser-mac
Mar 14, 2025

Conversation

@minrk
Copy link
Contributor

ensures web browser is launched on mac, even for URLs that are not http[s]. Only does the lookup for non-http URLs, limiting the impact of the change.

I'm not sure what level of testing is appropriate, but I added some basic exercise for MacOSXOSAScript. The subprocess is mocked, so the correctness of the applescript still itself isn't tested at all.

Addressesgh-128540 on macOS only. I'll open separate PRs per platform, as recommended by@ned-deily.

More discussion inhttps://discuss.python.org/t/support-for-file-urls-in-webbrowser-open/81612

Backported implementation inhttps://pypi.org/project/webbrowser-open/

ensures web browser is launched on mac, even for URLs that are not http[s].
@hugovkhugovk changed the titlegh-128540: lookup default webbrowser on macgh-128540: lookup default webbrowser on macOSFeb 25, 2025
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for all of your work on this issue. I'm going to approve to merge this for the next 3.14 alpha. We should try to get the other PRs reviewed and merged soon.

@ned-deilyned-deily merged commit9649278 intopython:mainMar 14, 2025
43 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable 3.x (tier-2) has failed when building commit9649278.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/125/builds/7186) and take a look at the build logs.
  4. Check if the failure is related to this commit (9649278) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/125/builds/7186

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_perf_profiler.py", line362, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertEqual(stderr,"")~~~~~~~~~~~~~~~~^^^^^^^^^^^^AssertionError:'Warning:\nProcessed 713 events and lost 2[34 chars]\n\n' != ''- Warning:- Processed 713 events and lost 2 chunks!- - Check IO/CPU overload!- Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_perf_profiler.py", line366, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertIn(f"py::baz:{script}", stdout)~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 'py::baz:/tmp/test_python_x1qo3nl3/tmp0ewxo348/perftest.py' not found in 'python  393427 795965.336329:          1 cycles:Pu: \n\t    ffffa3595ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython  393427 795965.336354:          1 cycles:Pu: \n\t    ffffa3595ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython  393427 795965.337077:          1 cycles:Pu: \n\t    ffffa35875b0 <invalid>+0x650 (inlined)\n\t    ffffa35875b0 <invalid>+0x650 (inlined)\n\t    ffffa35875b0 _dl_relocate_object+0x650 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa359344f dl_main+0x164f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa35905ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa3591b17 _dl_start_final+0x5ab (inlined)\n\t    ffffa3591b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa3595ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython  393427 795965.337097:        424 cycles:Pu: \n\t    ffffa35875ac <invalid>+0x64c (inlined)\n\t    ffffa35875ac <invalid>+0x64c (inlined)\n\t    ffffa35875ac _dl_relocate_object+0x64c (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa359344f dl_main+0x164f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa35905ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa3591b17 _dl_start_final+0x5ab (inlined)\n\t    ffffa3591b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa3595ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython  393427 795965.338092:       1111 cycles:Pu: \n\t    ffffa3593450 dl_main+0x1650 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa35905ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa3591b17 _dl_start_final+0x5ab (inlined)\n\t    ffffa3591b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa3595ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython  393427 795965.338290:      63626 cycles:Pu: \n\t    ffffa357ef08 _dl_init+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffa3595af7 _dl_start_user+0x37 (inlined)\n\npython  393427 795965.339200:     136406 cycles:Pu: \n\t    ffffa2f29840 _PyInterpreterState_Main+0x0 (inlined)\n\t    ffffa2f29840 _Py_IsMainInterpreter+0x0 (inlined)\n\t    ffffa2f29840 _PyFloat_InitState+0x0 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffa305d1bf pycore_init_global_objects+0x17 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffa3200e8b pycore_interp_init+0x2b (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffa32059eb pyinit_config+0xaf (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffa3217dab pyinit_core+0xdb (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so.1.0)\n\t    ffffa321858b Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/build_oot/libpython3.14d.so

plashchynski pushed a commit to plashchynski/cpython that referenced this pull requestMar 17, 2025
Ensure web browser is launched by `webbrowser.open` on macOS, even for `file://` URLs.
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Ensure web browser is launched by `webbrowser.open` on macOS, even for `file://` URLs.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ned-deilyned-deilyned-deily approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@minrk@bedevere-bot@ned-deily
[8]ページ先頭
©2009-2025 Movatter.jp