Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130482: Add ability to specify name fortkinter.OptionMenu andtkinter.ttk.OptionMenu#130502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Xiaokang2022
Copy link
Contributor

@Xiaokang2022Xiaokang2022 commentedFeb 24, 2025•
edited by bedevere-appbot
Loading

@Xiaokang2022
Copy link
ContributorAuthor

@serhiy-storchaka Sorry to bother you, can you please help review this PR? Thank you so much!

@serhiy-storchakaserhiy-storchaka self-requested a reviewMay 1, 2025 14:24
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

I left few suggestions for tests. You can accept them or reject.

Xiaokang2022and others added2 commitsMay 2, 2025 13:57
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@Xiaokang2022
Copy link
ContributorAuthor

LGTM. 👍

I left few suggestions for tests. You can accept them or reject.

Thank you for helping to review this PR. I have accepted all of your suggestions.

@serhiy-storchakaserhiy-storchaka merged commite490c00 intopython:mainMay 2, 2025
39 checks passed
@serhiy-storchaka
Copy link
Member

Thank you for your contribution@Xiaokang2022.

Xiaokang2022 reacted with heart emoji

@Xiaokang2022Xiaokang2022 deleted the improve-OptionMenu branchMay 2, 2025 11:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@kurawlefaraazkurawlefaraazkurawlefaraaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Xiaokang2022@serhiy-storchaka@kurawlefaraaz
[8]ページ先頭
©2009-2025 Movatter.jp