Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-125377: Improve tab indentation for pdb multi-line input#130471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@gaogaotiantian
Copy link
Member

@gaogaotiantiangaogaotiantian commentedFeb 22, 2025
edited by bedevere-appbot
Loading

We supported multi-line input in pdb in 3.13, but the tab indentation does not work in its best shape. It inserts a\t character, which means the first<tab> will introduce a 2-space (at least looks like it) indentation, and the next ones will introduce a 8-space one.

This PR made it a bit smarter. Now a<tab> at the beginning of the line (before any non-space text) will auto-fill a 4-space indentation. For example,\t and \t will both create a 4-space indentation.

This is not the smartest feature, it's not as good as pyrepl where the indentation is inserted when a new line is created. However, I think it's much better than what we have now.

The ultimate goal is to use pyrepl for pdb, so I don't think duplication too much code to make pdb work slightly better now is that rewarding.

@@ -0,0 +1 @@
``<tab>`` at the beginning of the line in:mod:`pdb` multi-line input will fill in a 4-space indentation now, instead of inserting a ``\t`` character.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd add this to what's new in 3.14.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done.

@gaogaotiantiangaogaotiantian merged commitb6769e9 intopython:mainMar 4, 2025
43 checks passed
@gaogaotiantiangaogaotiantian deleted the multiline-completion branchMarch 5, 2025 01:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@tomasr8tomasr8tomasr8 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaogaotiantian@iritkatriel@tomasr8

[8]ページ先頭

©2009-2025 Movatter.jp