Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-125377: Improve tab indentation for pdb multi-line input#130471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| @@ -0,0 +1 @@ | |||
| ``<tab>`` at the beginning of the line in:mod:`pdb` multi-line input will fill in a 4-space indentation now, instead of inserting a ``\t`` character. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd add this to what's new in 3.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
b6769e9 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
We supported multi-line input in pdb in 3.13, but the tab indentation does not work in its best shape. It inserts a
\tcharacter, which means the first<tab>will introduce a 2-space (at least looks like it) indentation, and the next ones will introduce a 8-space one.This PR made it a bit smarter. Now a
<tab>at the beginning of the line (before any non-space text) will auto-fill a 4-space indentation. For example,\tand\twill both create a 4-space indentation.This is not the smartest feature, it's not as good as pyrepl where the indentation is inserted when a new line is created. However, I think it's much better than what we have now.
The ultimate goal is to use pyrepl for pdb, so I don't think duplication too much code to make pdb work slightly better now is that rewarding.