Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-128627: Skip wasm-gc on iOS Safari where it's broken#130418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.Downstream pyodide issue:pyodide/pyodide#5428.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.
ambv added a commit to ambv/pyodide that referenced this pull requestFeb 21, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
ambv added a commit to ambv/pyodide that referenced this pull requestFeb 21, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load.Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane approved these changesFeb 21, 2025
Thanks@ambv! |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
freakboy3742 approved these changesFeb 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM - Thanks for the fix!
72ea3c0 intopython:main 45 checks passed
Uh oh!
There was an error while loading.Please reload this page.
hoodmane pushed a commit to pyodide/pyodide that referenced this pull requestFeb 24, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolves#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 24, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 25, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
hoodmane pushed a commit to hoodmane/pyodide that referenced this pull requestFeb 26, 2025
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Upstream pull request:python/cpython#130418.macOS Safari 18.3 does not surface the issue.Confirmed on device that disabling this restores interpreter function.Resolvespyodide#5428.
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…#130418)As of iOS 18.3.1, enabling wasm-gc breaks the interpreter. This disables the wasm-gctrampoline on iOS.Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As of iOS 18.3.1, enabling wasm-gc is making the interpreter fail to load. Downstream pyodide issue:pyodide/pyodide#5428.
macOS Safari 18.3 does not surface the issue.
Confirmed on device that disabling this restores interpreter function.