Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-130293: Ensure test__colorize will pass on dumb terminals.#130333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
!buildbot iOS |
bedevere-bot commentedFeb 20, 2025
🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commit096c689 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130333%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
Misc/NEWS.d/next/Tests/2025-02-20-13-39-12.gh-issue-130293.5igSsu.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Tests/2025-02-20-13-39-12.gh-issue-130293.5igSsu.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
1b07006 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ythonGH-130333)Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>(cherry picked from commit1b07006)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
GH-130334 is a backport of this pull request to the3.13 branch. |
…nals. (pythonGH-130333) (python#130334)Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)(cherry picked from commit1b07006)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
…nals. (pythonGH-130333) (python#130334)Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)(cherry picked from commit1b07006)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
…als. (pythonGH-130333) (python#130334)Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)(cherry picked from commit1b07006)Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Uh oh!
There was an error while loading.Please reload this page.
#129140 slightly modified the logic associated with determining if a console could be colorised. In doing so, the test became sensitive to the test environment's value for the TERM setting.
The iOS 18.2 test simulator sets
TERM=dumbin the test environment - this makes some sense, as stdout/stderr handling is performed by the system log, which won't honor tty control sequences.This appears to be a recent change to iOS; it wasn't true in iOS 17.2. With the recent update to the iOS buildbot, the problem became apparent.
However, the issue isn't iOS specific - it will occur on any machine where
TERM=dumbis set in the testing environment. On macOS, I can reproduce the issue with:This PR ensures that TERM is correctly mocked as part of the colorise test, and normalizes the name used by the iOS Testbed to disable terminal colors.