Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130160: use.. program:: directive for documentingidle CLI#130278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Mr-Sunglasses
Copy link
Contributor

@Mr-SunglassesMr-Sunglasses commentedFeb 18, 2025•
edited by github-actionsbot
Loading

@StanFromIreland
Copy link
Contributor

StanFromIreland commentedFeb 19, 2025•
edited
Loading

I don't think we can use these here because of how help.py for idle is generated. This may destroy the nice indentation we currently have?

New

image

Old

image

Also please run idlelib.help.copy_strip() so that help.html is updated.

Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Make changes, but I will want to review some of the other explanation lines before merging.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Mr-Sunglasses
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-app
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
terryjreedyand others added3 commitsFebruary 23, 2025 20:55
Split long line.Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Emphasize *options*.Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@terryjreedyterryjreedy dismissed theirstale reviewFebruary 24, 2025 01:59

Satisfied with changes.

@terryjreedyterryjreedyenabled auto-merge (squash)February 24, 2025 02:01
@terryjreedyterryjreedy merged commit0ff1611 intopython:mainFeb 24, 2025
27 of 28 checks passed
@miss-islington-app
Copy link

Thanks@Mr-Sunglasses for the PR, and@terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 24, 2025
…CLI (pythonGH-130278)---------Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>(cherry picked from commit0ff1611)Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
@bedevere-app
Copy link

GH-130494 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelFeb 24, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 24, 2025
…CLI (pythonGH-130278)---------Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>(cherry picked from commit0ff1611)Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
@bedevere-app
Copy link

GH-130495 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 24, 2025
terryjreedy pushed a commit that referenced this pull requestFeb 24, 2025
… CLI (GH-130278) (#130494)gh-130160: use `.. program::` directive for documenting `idle` CLI (GH-130278)---------(cherry picked from commit0ff1611)Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
terryjreedy pushed a commit that referenced this pull requestFeb 24, 2025
… CLI (GH-130278) (#130495)gh-130160: use `.. program::` directive for documenting `idle` CLI (GH-130278)---------(cherry picked from commit0ff1611)Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…CLI (python#130278)---------Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

@picnixzpicnixzpicnixz left review comments

@terryjreedyterryjreedyterryjreedy left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use.. program:: and.. option:: directives for modules with a documented CLI
5 participants
@Mr-Sunglasses@StanFromIreland@AA-Turner@picnixz@terryjreedy
[8]ページ先頭
©2009-2025 Movatter.jp