Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.10] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (GH-122566)#130268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 6 commits intopython:3.10fromhugovk:backport-fc233f4-3.10
Feb 19, 2025

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedFeb 18, 2025
edited by bedevere-appbot
Loading

(cherry picked from commitfc233f4)

Theubuntu-20.04 image is deprecated and will be fully unsupported by 2025-04-01:actions/runner-images#11101.

Plus some other things like quotes and zizmor fixes frommain.

…4.04 (pythonGH-122566)(cherry picked from commitfc233f4)Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
@hugovk
Copy link
MemberAuthor

Some Tk test failures onubuntu-24.04:

2 tests failed:    test_tk test_ttk_guionly10 tests skipped:    test_devpoll test_ioctl test_kqueue test_msilib test_nis    test_startfile test_winconsoleio test_winreg test_winsound    test_zipfile640:06:59 load avg: 2.880:06:59 load avg: 2.88 Re-running failed tests in verbose mode0:06:59 load avg: 2.88 Re-running test_tk in verbose mode (matching: test_itemconfigure, test_configure_tabs)patchlevel = 8.6.14test_itemconfigure (tkinter.test.test_tkinter.test_widgets.ListboxTest) ... FAILtest_configure_tabs (tkinter.test.test_tkinter.test_widgets.TextTest) ... FAIL======================================================================FAIL:test_itemconfigure (tkinter.test.test_tkinter.test_widgets.ListboxTest)----------------------------------------------------------------------Traceback (most recent call last):  File"/home/runner/work/cpython/cpython/Lib/tkinter/test/test_tkinter/test_widgets.py", line1017, intest_itemconfigureself.assertEqual(widget.itemconfigure(0,'background'),AssertionError:Tuples differ: ('background', '', '', '', 'red') != ('background', 'background', 'Background', '', 'red')First differing element 1:'''background'- ('background', '', '', '', 'red')+ ('background', 'background', 'Background', '', 'red')======================================================================FAIL:test_configure_tabs (tkinter.test.test_tkinter.test_widgets.TextTest)----------------------------------------------------------------------Traceback (most recent call last):  File"/home/runner/work/cpython/cpython/Lib/tkinter/test/test_tkinter/test_widgets.py", line678, intest_configure_tabsself.checkParam(widget,'tabs','10.2 20.7 1i 2i',  File"/home/runner/work/cpython/cpython/Lib/tkinter/test/widget_tests.py", line62, incheckParamself.assertEqual2(widget[name], expected,eq=eq)  File"/home/runner/work/cpython/cpython/Lib/tkinter/test/widget_tests.py", line46, inassertEqual2self.assertEqual(actual, expected, msg)AssertionError:Tuples differ: (10.2, 20.7, <pixel object: '1i'>, <pixel object: '2i'>) != ('10.2', '20.7', '1i', '2i')First differing element 0:10.2'10.2'- (10.2, 20.7, <pixel object: '1i'>, <pixel object: '2i'>)+ ('10.2', '20.7', '1i', '2i')----------------------------------------------------------------------Ran 2 tests in 0.044sAssertionError:Tuples differ: (0,) != ('0',)First differing element 0:0'0'- (0,)+ ('0',)?  + +======================================================================FAIL:test_configure_padding (tkinter.test.test_ttk.test_widgets.TreeviewTest)----------------------------------------------------------------------Traceback (most recent call last):  File"/home/runner/work/cpython/cpython/Lib/tkinter/test/test_ttk/test_widgets.py", line31, intest_configure_paddingself.checkParam(widget,'padding',0,expected=('0',))  File"/home/runner/work/cpython/cpython/Lib/tkinter/test/widget_tests.py", line62, incheckParamself.assertEqual2(widget[name], expected,eq=eq)  File"/home/runner/work/cpython/cpython/Lib/tkinter/test/widget_tests.py", line46, inassertEqual2self.assertEqual(actual, expected, msg)AssertionError:Tuples differ: (0,) != ('0',)First differing element 0:0'0'- (0,)+ ('0',)?  + +

https://github.com/python/cpython/actions/runs/13393281565/job/37405891542?pr=130268

Also fail withubuntu-22.04:

https://github.com/hugovk/cpython/actions/runs/13393591071/job/37406977865

@hugovk
Copy link
MemberAuthor

OK, those are#107262, which tracks because Tk has been upgraded to 8.6.14. I've cherry picked it into this one and it passes (with a small adjustment).

I've opened proper backports for that, let's merge those and then we can update it into this.

@hugovkhugovk marked this pull request as ready for reviewFebruary 19, 2025 09:09
@hugovk
Copy link
MemberAuthor

Ready!

@pablogsal This is like#130260 but for 3.10:

We need to upgrade the CI away fromubuntu-20.04 because it's going away soon:actions/runner-images#11101. The change of OS version means we get a new ABI file, so pinging you on this.

@ambvambv changed the title[3.10] gh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (GH-122566)[3.10] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (GH-122566)Feb 19, 2025
@ambvambv merged commit457b2ca intopython:3.10Feb 19, 2025
17 checks passed
@hugovkhugovk deleted the backport-fc233f4-3.10 branchFebruary 19, 2025 13:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiezio-melotti approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsal

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@hugovk@ezio-melotti@ambv@Damien-Chen@DBJim

[8]ページ先頭

©2009-2025 Movatter.jp