Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.11] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (#122566)#130260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ython#122566)(cherry picked from commitfc233f4)
hugovk commentedFeb 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Let's go through these one-by-one. ABI check first, https://devguide.python.org/getting-started/setup-building/index.html#regenerate-the-abi-dump |
With
But they pass with |
@pablogsal We need to upgrade the CI away from |
@@ -87,11 +87,13 @@ jobs: | |||
check_abi: | |||
name: 'Check if the ABI has changed' | |||
runs-on: ubuntu-20.04 | |||
runs-on: ubuntu-22.04 # 24.04 causes spurious errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you know if these are the same errors that we just saw about the missing bits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't know, the comment was added in#126619 and the logs have since expired:https://github.com/python/cpython/actions/runs/11853955712/job/33035153091?pr=126619.
Makes sense thanks a lot for the fix! |
b2c3a95
intopython:3.11Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
(cherry picked from commitfc233f4)
The
ubuntu-20.04
image is deprecated and will be fully unsupported by 2025-04-01:actions/runner-images#11101.Plus some other things like quotes and zizmor fixes from
main
.