Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.11] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (#122566)#130260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 3 commits intopython:3.11fromhugovk:backport-fc233f4-3.11
Feb 18, 2025

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedFeb 18, 2025
edited by bedevere-appbot
Loading

(cherry picked from commitfc233f4)

Theubuntu-20.04 image is deprecated and will be fully unsupported by 2025-04-01:actions/runner-images#11101.

Plus some other things like quotes and zizmor fixes frommain.

@hugovk
Copy link
MemberAuthor

hugovk commentedFeb 18, 2025
edited
Loading

Let's go through these one-by-one. ABI check first,python3.11 has changed when usingubuntu-22.04 instead ofubuntu-20.04. I'll add the changed file here, and include the RM when the PR is ready for merge.

https://devguide.python.org/getting-started/setup-building/index.html#regenerate-the-abi-dump

ezio-melotti reacted with thumbs up emoji

@hugovkhugovk closed thisFeb 18, 2025
@hugovkhugovk reopened thisFeb 18, 2025
@hugovk
Copy link
MemberAuthor

Withubuntu-24.04, "Ubuntu / build and test (ubuntu-24.04)" and "Address sanitizer" fail with:

The necessary bits to build these optional modules were not found:nis                                                            To find the necessary bits, look in setup.py in detect_modules() for the module's name.

But they pass withubuntu-22.04 so it's enough to get them offubuntu-20.04.

ezio-melotti reacted with thumbs up emoji

@hugovkhugovk marked this pull request as ready for reviewFebruary 18, 2025 14:32
@hugovk
Copy link
MemberAuthor

@pablogsal We need to upgrade the CI away fromubuntu-20.04 because it's going away soon:actions/runner-images#11101. The change of OS version means we get a new ABI file, so pinging you on this.

pablogsal reacted with thumbs up emoji

@@ -87,11 +87,13 @@ jobs:

check_abi:
name: 'Check if the ABI has changed'
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04 # 24.04 causes spurious errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do you know if these are the same errors that we just saw about the missing bits?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know, the comment was added in#126619 and the logs have since expired:https://github.com/python/cpython/actions/runs/11853955712/job/33035153091?pr=126619.

ezio-melotti reacted with thumbs up emoji
@pablogsal
Copy link
Member

@pablogsal We need to upgrade the CI away fromubuntu-20.04 because it's going away soon:actions/runner-images#11101. The change of OS version means we get a new ABI file, so pinging you on this.

Makes sense thanks a lot for the fix!

hugovk and ambv reacted with thumbs up emoji

@pablogsalpablogsal merged commitb2c3a95 intopython:3.11Feb 18, 2025
28 checks passed
@hugovkhugovk deleted the backport-fc233f4-3.11 branchFebruary 19, 2025 06:34
@ambvambv changed the title[3.11] gh-122544: Change OS image in GitHub Actions to Ubuntu 24.04 (#122566)[3.11] gh-122544: Change OS image in GitHub Actions to Ubuntu 22.04 (#122566)Feb 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal approved these changes

@ezio-melottiezio-melottiezio-melotti approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@hugovk@pablogsal@ezio-melotti@Damien-Chen

[8]ページ先頭

©2009-2025 Movatter.jp