Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130160: use.. program:: directive for documentingensurepip CLI#130253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pfmoore merged 2 commits intopython:mainfromMr-Sunglasses:fix/130160
Feb 18, 2025

Conversation

Mr-Sunglasses
Copy link
Contributor

@Mr-SunglassesMr-Sunglasses commentedFeb 18, 2025•
edited by github-actionsbot
Loading

shashwat2003 and ai-man-codes reacted with hooray emoji
@ghost
Copy link

ghost commentedFeb 18, 2025•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@Mr-Sunglasses
Copy link
ContributorAuthor

@sobolevn ,@picnixz ptal

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!
Снимок экрана 2025-02-18 в 14 08 39

I would recommend changingpipX topipN, because there's now a tool calledpipx.

Thanks for the PR and congrats! 🎉

Mr-Sunglasses reacted with heart emoji
@@ -75,14 +75,14 @@ through two additional command line options:
for the current Python installation (this option is not permitted inside an
active virtual environment).

By default, the scripts ``pipX`` and ``pipX.Y`` will be installed (where
X.Y stands for the version of Python used to invoke ``ensurepip``). The
By default, the scripts ``pipN`` and ``pipN.Y`` will be installed (where
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

MaybepipN.M?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why change this at all?pipX.Y is the normal convention here, used in the pip documentation.

Mr-Sunglasses reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok, this change is unrelated anyway and no users complained about it. I agree with@pfmoore

Mr-Sunglasses reacted with thumbs up emoji
Copy link
Member

@pfmoorepfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please leave thepipX.Y naming convention unchanged.

Mr-Sunglasses reacted with thumbs up emoji
@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pfmoore
Copy link
Member

Sorry I hadn’t seen the comment by@sobolevn regarding thepipx application. Nevertheless, I disagree - thepipX.Y convention is well established, and consistency with existing terminology is important.

Mr-Sunglasses reacted with thumbs up emoji

@Mr-Sunglasses
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-app
Copy link

Thanks for making the requested changes!

@pfmoore: please review the changes made to this pull request.

@pfmoore
Copy link
Member

Thanks! LGTM.

@pfmoorepfmoore merged commit8cd7f8b intopython:mainFeb 18, 2025
49 of 52 checks passed
@sobolevn
Copy link
Member

We usually backport doc changes, should we in this case?

@sobolevnsobolevn added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsFeb 18, 2025
@miss-islington-app
Copy link

Thanks@Mr-Sunglasses for the PR, and@pfmoore for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks@Mr-Sunglasses for the PR, and@pfmoore for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 18, 2025
…pip` CLI (pythongh-130253)(cherry picked from commit8cd7f8b)Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
@bedevere-app
Copy link

GH-130258 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 18, 2025
…pip` CLI (pythongh-130253)(cherry picked from commit8cd7f8b)Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
@bedevere-app
Copy link

GH-130259 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelFeb 18, 2025
@pfmoore
Copy link
Member

We usually backport doc changes, should we in this case?

I don't know the policy for doc changes, but if that's the usual approach, I see no reason not to.

pfmoore pushed a commit that referenced this pull requestFeb 18, 2025
…epip` CLI (gh-130253) (gh-130259)gh-130160: use `.. program::` directive for documenting `ensurepip` CLI (gh-130253)(cherry picked from commit8cd7f8b)Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
pfmoore pushed a commit that referenced this pull requestFeb 18, 2025
…epip` CLI (gh-130253) (gh-130258)gh-130160: use `.. program::` directive for documenting `ensurepip` CLI (gh-130253)(cherry picked from commit8cd7f8b)Co-authored-by: Kanishk Pachauri <itskanishkp.py@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sobolevnsobolevnsobolevn left review comments

@pfmoorepfmoorepfmoore approved these changes

@pradyunsgpradyunsgAwaiting requested review from pradyunsgpradyunsg is a code owner

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use.. program:: and.. option:: directives for modules with a documented CLI
3 participants
@Mr-Sunglasses@pfmoore@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp