Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-129107: two cases where second operand needs lock#130227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 9 commits intopython:mainfromtom-pytel:fix-issue-129107b
Feb 27, 2025

Conversation

@tom-pytel
Copy link
Contributor

@tom-pyteltom-pytel commentedFeb 17, 2025•
edited
Loading

Identified three cases where a second operand needs to be locked. Also double checked other two operand functions:

  • PyByteArray_Concat
  • bytearray_richcompare

But those "lock" both self and their counterparts purely through the buffer mechanism so there are no issues in those.

@tom-pytel
Copy link
ContributorAuthor

Ping@kumaraditya303

@tom-pytel
Copy link
ContributorAuthor

I added a lock for the second operand inbytearray_iconcat as well because self is locked and getting the buffer for the second operand may involve locking self for that operand (as it does inbytearray).

@tom-pytel
Copy link
ContributorAuthor

ping@colesbury

@kumaraditya303kumaraditya303 merged commite85f81f intopython:mainFeb 27, 2025
46 checks passed
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tomasr8tomasr8tomasr8 left review comments

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tom-pytel@tomasr8@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp