Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-118761: Revert "Improve import time ofsubprocess (GH-129427)"#130201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
gpshead merged 3 commits intopython:mainfromgpshead:revert-pr129427-subprocess-lazy-importsFeb 16, 2025
Merged
gh-118761: Revert "Improve import time ofsubprocess (GH-129427)"#130201
gpshead merged 3 commits intopython:mainfromgpshead:revert-pr129427-subprocess-lazy-importsFeb 16, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…H-129427)"This reverts commit49f2465.This caused bugs in the `__del__` finalizer:python#118761 (comment)
picnixz approved these changesFeb 16, 2025
Misc/NEWS.d/next/Library/2025-02-16-10-12-27.gh-issue-118761.TNw5ZC.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…Nw5ZC.rstCo-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Member
picnixz commentedFeb 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Actually, shouldn't we remove the previous NEWS entry? I don't know whether it makes sense to have it in the changelog in this case (but if one downloads an exact version they could have it =/) |
MemberAuthor
gpshead commentedFeb 16, 2025
This has already shipped in releases. |
MemberAuthor
gpshead commentedFeb 16, 2025
So the new NEWS entry is a correction for the previous one. |
ae30646 intopython:main 39 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 16, 2025
…H-129427)" (pythonGH-130201)* Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)"This reverts commit49f2465.Also known asf502c8f in 3.13 (PRpythonGH-129447)Also known asf65aa0d in 3.12 (PRpythonGH-129448)This caused bugs in the `__del__` finalizer:python#118761 (comment)---------(cherry picked from commitae30646)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-130204 is a backport of this pull request to the3.13 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 16, 2025
…H-129427)" (pythonGH-130201)* Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)"This reverts commit49f2465.Also known asf502c8f in 3.13 (PRpythonGH-129447)Also known asf65aa0d in 3.12 (PRpythonGH-129448)This caused bugs in the `__del__` finalizer:python#118761 (comment)---------(cherry picked from commitae30646)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
GH-130205 is a backport of this pull request to the3.12 branch. |
gpshead added a commit that referenced this pull requestFeb 16, 2025
)" (GH-130201) (#130205)gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201)* Revert "gh-118761: Improve import time of `subprocess` (GH-129427)"This reverts commit49f2465.Also known asf502c8f in 3.13 (PRGH-129447)Also known asf65aa0d in 3.12 (PRGH-129448)This caused bugs in the `__del__` finalizer:#118761 (comment)---------(cherry picked from commitae30646)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
gpshead added a commit that referenced this pull requestFeb 16, 2025
)" (GH-130201) (#130204)gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201)* Revert "gh-118761: Improve import time of `subprocess` (GH-129427)"This reverts commit49f2465.Also known asf502c8f in 3.13 (PRGH-129447)Also known asf65aa0d in 3.12 (PRGH-129448)This caused bugs in the `__del__` finalizer:#118761 (comment)---------(cherry picked from commitae30646)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This reverts commit49f2465.
This caused bugs in the
__del__finalizer:#118761 (comment)