Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
CI: Use ImageOS (ubuntu24) instead of runner.os (Linux) in cache keys#130200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| - name: Runner image version | ||
| run: echo "IMAGE_VERSION=${ImageVersion}" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was set but not used in this job.
| - name: "Runner image version" | ||
| run: echo "IMAGE_OS_VERSION=${ImageOS}-${ImageVersion}" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This wasn't being set in this job, soenv.IMAGE_VERSION was evaluating as an empty string in the keys below.
3d7a141 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry,@hugovk, I could not cleanly backport this to |
Sorry,@hugovk, I could not cleanly backport this to |
…he keys (pythonGH-130200)(cherry picked from commit3d7a141)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-130222 is a backport of this pull request to the3.13 branch. |
…he keys (pythonGH-130200)(cherry picked from commit3d7a141)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-130226 is a backport of this pull request to the3.12 branch. |
hugovk commentedFeb 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
And let's backport to 3.9-3.11 because they're still using |
Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry,@hugovk, I could not cleanly backport this to |
Sorry,@hugovk, I could not cleanly backport this to |
Sorry,@hugovk, I could not cleanly backport this to |
GH-130252 is a backport of this pull request to the3.11 branch. |
3.9 and 3.10 don't have these cache keys so don't need this backport. |
Problem
In#129834 we recently switched the
ubuntu-24.04-armrunners toubuntu-22.04-arm.However, the CI jobs consistently broken due to an unknown GCC option:
After clearing the config caches, a re-run passed:
This was the cache key for "Restore config.cache" is:
Which evaluates to
build_ubuntu_reusable-Linux-0.0.10-9cf14f6717fb4cec718ff086229088aa00b4e898b87da1d8f14119ec638f68e7for both runners.That is because
runner.osisLinuxandenv.IMAGE_VERSIONis0.0.10for both.So they both used the same cache.
Fix
env.IMAGE_VERSIONcomes from$ImageVersion, and there's also a$ImageOSwhich givesubuntu22orubuntu24.This will give us a fresh cache when we next change the OS version.