Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-130167: Improve speed ofdifflib.IS_LINE_JUNK
by replacingre
#130170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
8f2670d
Improve speed of difflib.IS_LINE_JUNK by replacing re
donBarbos0fae9c5
Update difflib.py
donBarbos352b4bc
Update difflib.py
donBarbos0ab8da8
Add backward compatibility
donBarbos64dff4a
Update difflib.py
donBarbos32337c3
Update Lib/difflib.py
donBarbos390b6e7
Update difflib.py
donBarbos30d4535
Back `iff` word
donBarbos0e7293d
Update difflib
donBarbosbcf45a3
Update difflib.py
donBarbos46a4126
Fix News message
donBarbos60951fb
Improve clarity of expression
AA-Turner9d987b4
Revert, but add explanatory comments
AA-TurnerFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Update difflib
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit0e7293d752be5d54cca43625b95a6afbefb61176
There are no files selected for viewing
3 changes: 1 addition & 2 deletionsLib/difflib.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1053,8 +1053,7 @@ def IS_LINE_JUNK(line, pat=None): | ||
""" | ||
if pat is None: | ||
return line.strip() in ('', '#') | ||
donBarbos marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
return pat(line) is not None | ||
def IS_CHARACTER_JUNK(ch, ws=" \t"): | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.