Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-130141: clean up asyncio._SelectorTransport during __del__#130142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
aligns the SelectorTransport __del__ implementation with force_closealso sets sock_fd to -1 when closing the socket so stale fds can't bereused
| self._sock = None | ||
| self._protocol = None | ||
| self._loop = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What's the reason for setting loop to None?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| self._loop._remove_writer(self._sock_fd) | ||
| self._conn_lost += 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why this change?
Uh oh!
There was an error while loading.Please reload this page.
_SelectorTransportunregisters fds it doesn't own #130141