Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127260: Make more consistent to raising errors offromisoformat methods in both implementations#130134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pganssle merged 5 commits intopython:mainfromdonBarbos:issue-127260
Feb 18, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbosdonBarbos commentedFeb 14, 2025•
edited by bedevere-appbot
Loading

My fixes forfromisoformat method:

  • _pydatetime implementation raise error if there are extra characters afterZ like in_datetime implementation (this was documented)
  • _pydatetime implementation also support: as microsecond separator like in_datetime implementation (I didn't find this in documentation)
  • same first raised error (see related issue, example 3)
  • add tests to check that both implementations work the same way

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@donBarbos
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

Emphasize the change in strictness in the C implementation.
Copy link
Member

@pgansslepganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for another great PR@donBarbos!

donBarbos reacted with heart emoji
@donBarbos
Copy link
ContributorAuthor

Thank you for review

@pgansslepganssleenabled auto-merge (squash)February 18, 2025 14:55
@pgansslepganssle merged commit427dd10 intopython:mainFeb 18, 2025
42 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pgansslepgansslepganssle approved these changes

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@donBarbos@pganssle
[8]ページ先頭
©2009-2025 Movatter.jp