Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130080: implement PEP 765#130087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 22 commits intopython:mainfromiritkatriel:pep-765
Mar 17, 2025
Merged

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedFeb 13, 2025•
edited
Loading

Copy link
Member

@markshannonmarkshannon left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but I'm not sure I entirely trust the overwrite/save/overwrite logic.

Saving, overwriting and then overwriting again seems an error prone way to maintain a stack of the current context.ControlFlowInFinallyState can fit in a single byte and the depth of try-finally is limited to 20 (CO_MAXBLOCKS) so a stack will only take 20 bytes or so.

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@iritkatriel
Copy link
MemberAuthor

I have made the requested changes; please review again.

@iritkatriel
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-app
Copy link

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There are two unused fields in_PyASTOptimizeState that need removing, otherwise looks good.

intff_features;
intsyntax_check_only;

intrecursion_depth;/* current recursion depth */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This doesn't appear to be used anywhere (same forrecursion_limit)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks. I think they were removed in the const folding PRs after I created this one.

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some docs comments.

*:ref:`PEP 741: Python Configuration C API<whatsnew314-pep741>`
*:ref:`PEP 761: Discontinuation of PGP signatures<whatsnew314-pep761>`
*:ref:`A new type of interpreter<whatsnew314-tail-call>`
*:ref:`PEP 765: Disallow return/break/continue that exit a finally block<whatsnew314-pep765>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For the reader, I think it may be better to have the PEP bullet points grouped.

iritkatrieland others added2 commitsMarch 17, 2025 20:12
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@iritkatrieliritkatrielenabled auto-merge (squash)March 17, 2025 20:30
@iritkatrieliritkatriel merged commitffc2f1d intopython:mainMar 17, 2025
42 checks passed
@AA-TurnerAA-Turner mentioned this pull requestMar 18, 2025
6 tasks
colesbury pushed a commit to colesbury/cpython that referenced this pull requestMar 20, 2025
seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
sobolevn added a commit that referenced this pull requestAug 2, 2025
)This is required so we would never have empty node bodies.Refs#130087
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 2, 2025
…pythonGH-137318)This is required so we would never have empty node bodies.RefspythonGH-130087(cherry picked from commitb74f3be)Co-authored-by: sobolevn <mail@sobolevn.me>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull requestAug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tomasr8tomasr8tomasr8 left review comments

@picnixzpicnixzpicnixz left review comments

@markshannonmarkshannonmarkshannon approved these changes

@ncoghlanncoghlanAwaiting requested review from ncoghlan

@isidenticalisidenticalAwaiting requested review from isidentical

@Eclips4Eclips4Awaiting requested review from Eclips4Eclips4 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

+1 more reviewer

@WolframAlphWolframAlphWolframAlph left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iritkatriel@tomasr8@markshannon@picnixz@WolframAlph
[8]ページ先頭
©2009-2025 Movatter.jp