Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-128540: Fixedwebbrowser.open withfile: URLs may launching editor instead of browser#130031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Wulian233 wants to merge1 commit intopython:mainfromWulian233:webbrowser-open

Conversation

@Wulian233
Copy link
Contributor

@Wulian233Wulian233 commentedFeb 12, 2025•
edited by bedevere-appbot
Loading

Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a breaking change. I know of at least one instance where this will cause a significant break: by default the Pythons installed using the python.org macOS installers include a copy of the Python HTML documentation. On macOS, IDLE will look for that copy of the HTML documentation and, if found, will attempt to open it by passing afile: URL towebbrowser.open. Browsing the docs in IDLE is usually invoked with the F1 key. With this PR, pressing F1 causes IDLE to do nothing. There may be other existing users ofwebbrowser.open that would be similarly affected. I'm not sure what the best solution is but as it stands I don't think we can apply this as is.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Wulian233
Copy link
ContributorAuthor

Wulian233 commentedFeb 13, 2025•
edited
Loading

This seems to be a case of mutual exclusivity, where supporting the needs of some users without adding a new parameter might not be feasible given the existing calls in Python. There's no way to control what behavior users actually want.jupyter-server/jupyter_server#1488

My only idea is to introduce a new parameter,open, defaulting toFalse. This would be a new feature (3.14+), and the browser would only open when explicitly set toTrue, while keeping the current behavior as the default.🤔 What do you think?

@ned-deily
Copy link
Member

ned-deily commentedFeb 13, 2025•
edited
Loading

After thinking about it some more, I commentedhere on the issue. Let's try to resolve that first before proceeding further with a code change. Thanks for working on it!

@Wulian233
Copy link
ContributorAuthor

The current behavior of webbrowser still needs discussion,#128540 (comment) I decided to close it for now 😊

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ned-deilyned-deilyned-deily requested changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wulian233@ned-deily
[8]ページ先頭
©2009-2025 Movatter.jp