Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
GH-91079: Implement C stack limits using addresses, not counters.#130007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
46 commits Select commitHold shift + click to select a range
fc910a3
Hide that C recursion protection is implemented with a counter. There…
markshannonafeb866
Implement C recursion protection with limit pointers
markshannon22ca169
Use uintptr_t instead of char * to avoid warnings and UB
markshannone8d8c4b
Merge branch 'main' into c-recursion-limit
markshannonb3638a5
Fix typo and update stable ABI
markshannon774efb5
Tweak AST test numbers
markshannon151c88f
Improve logic handling trial C stack overflow
markshannon350f8ec
Remove calls to PyOS_CheckStack
markshannon428c46a
Up the limits for recursion tests
markshannona9be141
Use deeper stack for test
markshannon03fc52e
Remove exceeds_recursion_limit and get_c_recursion_limit. Use platfor…
markshannonafac1e6
Do fewer probes when growing stack limit
markshannon9da904d
Tweak depths
markshannona802ff6
Merge branch 'main' into c-recursion-limit
markshannondbcf6f0
Perform lazy initialization of c recursion check
markshannon2cc3287
Post merge fixup
markshannone697926
Up depth again
markshannonf8a9143
Drop 'failing' depth
markshannon7d6d77f
Add news
markshannon31a83dc
Increase headroom
markshannon47c50aa
Update test
markshannon495c4ea
Tweak some more thresholds and tests
markshannon9e0cc67
Add stack protection to parser
markshannon857a7bb
Make tests more robust to low stacks
markshannon9c9326a
Improve error messages for stack overflow
markshannon75d3219
Merge branch 'main' into c-recursion-limit
markshannon3e41b46
Fix formatting
markshannon158401a
Halve size of WASI stack
markshannonc1eb229
Reduce webassembly 'stack size' by 10
markshannon7407d2b
Halve size of WASI stack, again
markshannon978b5e7
Change WASI stack back to 100k
markshannon7b36f59
Add many skip tests for WASI due to stack issues
markshannon5e5db03
Probe all pages when extending stack limits
markshannon82173ed
Fix compiler warnings
markshannon64cfd86
Use GetCurrentThreadStackLimits instead of probing with alloca
markshannone52137f
Refactor a bit
markshannon704c336
Merge branch 'main' into c-recursion-limit
markshannon21366c3
Fix logic error in test
markshannon7761d31
Make ABI function needed for Py_TRASHCAN_BEGIN private
markshannonb067e3e
Move new fields to _PyThreadStateImpl to avoid any potential API brea…
markshannonb0e695f
Fix missing cast
markshannonc4cd68f
yet another missing _
markshannon9654790
Tidy up a bit
markshannon2cef96f
Restore use of exceeds_recursion_limit
markshannonc5d8a40
Address remaining review comments
markshannon33e11c8
Merge branch 'main' into c-recursion-limit
markshannonFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Drop 'failing' depth
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitf8a9143ecd08ddab8426834faae02b3979d3c928
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.