Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-129926: Speed up sqlite3.Row item access#129927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cc.@picnixz |
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
The aarch64 fedora buildbot failure is unreleated. |
if (!PyUnicode_Check(left) || !PyUnicode_Check(right)) { | ||
return 0; | ||
} | ||
assert(PyUnicode_Check(left)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ifleft
andright
are always unicode, could we replace thePyObject_RichCompareBool
with a unicode comparison such asPyUnicode_Compare
for performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
They can be subclasses, in which casePyUnicode_Compare
won't trigger on custom__eq__
IIRC.
Uh oh!
There was an error while loading.Please reload this page.