Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-129926: Speed up sqlite3.Row item access#129927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
erlend-aasland wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromerlend-aasland:sqlite/speedup-row

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedFeb 10, 2025
edited by bedevere-appbot
Loading

@bedevere-appbedevere-appbot mentioned this pull requestFeb 10, 2025
@erlend-aaslanderlend-aasland linked an issueFeb 10, 2025 that may beclosed by this pull request
@erlend-aasland
Copy link
ContributorAuthor

cc.@picnixz

@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMar 31, 2025
@bedevere-bot

This comment was marked as outdated.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMar 31, 2025
@erlend-aasland
Copy link
ContributorAuthor

The aarch64 fedora buildbot failure is unreleated.

if (!PyUnicode_Check(left) || !PyUnicode_Check(right)) {
return 0;
}
assert(PyUnicode_Check(left));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ifleft andright are always unicode, could we replace thePyObject_RichCompareBool with a unicode comparison such asPyUnicode_Compare for performance?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

They can be subclasses, in which casePyUnicode_Compare won't trigger on custom__eq__ IIRC.

eendebakpt reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz left review comments

@eendebakpteendebakpteendebakpt approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up sqlite3.Row
4 participants
@erlend-aasland@bedevere-bot@eendebakpt@picnixz

[8]ページ先頭

©2009-2025 Movatter.jp