Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-97850: Update the deprecation warning ofimportlib.abc.Loader.load_module#129855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brettcannon merged 3 commits intopython:mainfromtomasr8:importlib-module-shim
Feb 11, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedFeb 8, 2025•
edited by github-actionsbot
Loading

The deprecation warning was added in 3.10 by#23469.

The warning currently states that the removal is planned for 3.12. I suggest we update it to say 3.15 which, following the 5 releases rule, is the earliest release in which the methods can be removed (whether or not we'll actually be able to do that is another question, but let's at least keep the warnings up to date).

Related discussion:#97850 (comment) ,#97850 (comment)

📚 Documentation preview 📚:https://cpython-previews--129855.org.readthedocs.build/

@brettcannonbrettcannon added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsFeb 11, 2025
@brettcannonbrettcannon merged commitaa81a6f intopython:mainFeb 11, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks@tomasr8 for the PR, and@brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 11, 2025
…er.load_module` (pythonGH-129855)(cherry picked from commitaa81a6f)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-130013 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelFeb 11, 2025
@miss-islington-app
Copy link

Sorry,@tomasr8 and@brettcannon, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker aa81a6f6e4f265565da9781d0bf95c7d16ddd961 3.12

@tomasr8
Copy link
MemberAuthor

I can look into the 3.12 backport later :)

brettcannon pushed a commit that referenced this pull requestFeb 11, 2025
…der.load_module` (GH-129855) (GH-130013)gh-97850: Update the deprecation warning of `importlib.abc.Loader.load_module` (GH-129855)(cherry picked from commitaa81a6f)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-130017 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 11, 2025
@tomasr8tomasr8 deleted the importlib-module-shim branchFebruary 11, 2025 20:48
brettcannon pushed a commit that referenced this pull requestFeb 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@brettcannonbrettcannonbrettcannon approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

@brettcannonbrettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@tomasr8@brettcannon
[8]ページ先頭
©2009-2025 Movatter.jp