Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-129719: Restore missing socket.CAN_RAW_ERR_FILTER on Linux#129721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jbogers
Copy link
Contributor

@jbogersjbogers commentedFeb 6, 2025•
edited by github-actionsbot
Loading

Restoresocket.CAN_RAW_ERR_FILTER on Linux by looking at theHAVE_LINUX_CAN_RAW_H flag, as thelinux/can/raw.h file defines this value in an enum and not a normal define.

Aslinux/can/raw.h should always contain the value, I believe this change is safe to make.

📚 Documentation preview 📚:https://cpython-previews--129721.org.readthedocs.build/

@ghost
Copy link

ghost commentedFeb 6, 2025•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

This comment was marked as resolved.

@bedevere-app

This comment was marked as resolved.

@jbogersjbogersforce-pushed thefix_can_raw_err_filter_in_socket_module branch fromc200548 tob20c686CompareFebruary 6, 2025 10:59
@bedevere-app

This comment was marked as resolved.

1 similar comment
@bedevere-app

This comment was marked as resolved.

@jbogersjbogersforce-pushed thefix_can_raw_err_filter_in_socket_module branch from2c5617a tobde35e3CompareFebruary 6, 2025 11:15
@bedevere-app

This comment was marked as resolved.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In the future, please don't force push; it just makes reviewing more difficult, and we squash merge at the end anyway.

Regarding the actual change: do we want to backport this? (Not to 3.11, but we could to 3.12+)

cc@erlend-aasland who added it originally, and@serhiy-storchaka who merged the offending PR (GH-30066).

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is trivial enough that we don't need a test. LGTM.

@jbogers
Copy link
ContributorAuthor

I think this is trivial enough that we don't need a test. LGTM.

There has been no activity on this PR for a while. Is there an action I (as PR creator) have to take to move this forward? Or do I just have to wait? Either is fine with me, but I'm unfamiliar with the process and I want to be sure I'm not the one holding this up now.

@sobolevn
Copy link
Member

Thank you, indeed the check is about

iftest"x$ac_cv_header_linux_can_raw_h" = xyesthen:printf"%s\n""#define HAVE_LINUX_CAN_RAW_H 1">>confdefs.hfi

@sobolevnsobolevn merged commitce31ae5 intopython:mainApr 18, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks@jbogers for the PR, and@sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 18, 2025
…pythonGH-129721)(cherry picked from commitce31ae5)Co-authored-by: Jeroen Bogers <11465689+jbogers@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

GH-132702 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 18, 2025
sobolevn pushed a commit that referenced this pull requestApr 18, 2025
GH-129721) (#132702)gh-129719: Restore missing `socket.CAN_RAW_ERR_FILTER` on Linux (GH-129721)(cherry picked from commitce31ae5)Co-authored-by: Jeroen Bogers <11465689+jbogers@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbogers@sobolevn@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp