Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-129646: Update the locale alias mapping#129647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks,@serhiy-storchaka Some of the edits made by the script are a bit odd. E.g. "de_li.utf8" is being removed, even though the original file still lists it:https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/master/nls/locale.alias.pre?ref_type=heads#L266 |
This is because "de_li" was added. The mapping does not contain all data from |
Ah, yes, you're right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
f61afca
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR, and@malemburg for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
*pythongh-129646: Update the locale alias mapping* Add a NEWS file.(cherry picked from commitf61afca)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-129658 is a backport of this pull request to the3.13 branch. |
Thanks,@serhiy-storchaka |
Thanks for merging, but please don't forget to edit commit messages. |
I haven't done this in CPython in a longer while. Can you point me to documentation about the needed edits ? |
I found this reference:https://devguide.python.org/getting-started/git-boot-camp/#accepting-and-merging-a-pull-request and it appears you are referring to the changing the way Github issues and PRs are referenced (using "GH-" instead of "#"). |
No, I meant that since the NEWS file was added in a separate commit, GitHub combined commit messages of several commit in a commit message of the merged commit. Seef61afca. It contains a duplicate of the title of the original commit message and the commit message of the following commit. In worst cases (e.g.4f82621) it can contain tens of useless lines that reflect the history of editing the PR, and not its final form. This is why we need to edit commit message before confirming merging. |
Ah, ok, I see. Yes, I should have taken a closer look before hitting merge. Will do next time. |
*pythongh-129646: Update the locale alias mapping* Add a NEWS file.
*pythongh-129646: Update the locale alias mapping* Add a NEWS file.
Uh oh!
There was an error while loading.Please reload this page.