Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-128317: Move CLI calendar highlighting to private class#129625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
encukou left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for doing this!
I'm not sure what the next step should be -- perhaps the API should be improved to make thiskind of customization easier; perhaps CLICalendar should be public. But, in plain text, avoiding terminal sequences is the right thing to do.
Misc/NEWS.d/next/Library/2025-02-03-22-31-43.gh-issue-128317.n2Swnh.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
hugovk commentedFeb 8, 2025
And thanks for the review! Re: next steps, I'm not planning on further changes to the calendar right now, although if theweek numbering idea progresses, we can consider things like that. |
1bccd6c intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Following@encukou's suggestions in#128317 (comment).
I've added a
NEWSfile because#128318 went out in 3.14a4, so I think this warrants one?📚 Documentation preview 📚:https://cpython-previews--129625.org.readthedocs.build/