Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.12] gh-129573: Fix abort from non-string suggestions incalculate_suggestions#129574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

devdanzin
Copy link
Contributor

@devdanzindevdanzin commentedFeb 2, 2025•
edited by bedevere-appbot
Loading

This PR adds a simple check that suggestion candidates are strings incalculate_suggestions, avoiding an abort in debug builds from code like below:

classParent:def__dir__(self):return [0]classWithNonStringAttrs(Parent):blech=NoneWithNonStringAttrs().bluch

Found usingfusil by@vstinner.

@devdanzindevdanzin changed the titlegh-129573: Fix abort from non-string suggestions incalculate_suggestions[3.12] gh-129573: Fix abort from non-string suggestions incalculate_suggestionsFeb 2, 2025
@ZeroIntensity
Copy link
Member

Thanks for doing this! See my comment:#129573 (comment)

The offending code isn't a problem on 3.13+, but it still exists. Please open a new PR for the main branch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@devdanzin@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp