Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Added filtering logic based on the included/excluded items in ns#129571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Added filtering logic based on the included/excluded items in ns
ghost commentedFeb 2, 2025 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This needs an issue, a news entry and an explanation of why this is needed. cc@zooba as the PC expert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not at all the filtering that was intended by the comment.
InPROPS_TEMPLATE you'll see XML elements for_PythonRuntimeExe and_PythonRuntimeDlls, some of which don't need to be included at all if the package doesn't include those files. Though the only really relevant ones arepython*.exe andpython*.dll for the cases where someone chooses to build a package that doesn't include Python itself (which would be weird).
So this is unnecessary, and probably marking the comment "TODO" is too attractive for contributions when really it should just say "We don't filter based on contents, so if you expected it, that's why" to help out anyone who comes looking at the code to figure out why their weird incantation isn't working.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
Added filtering logic based on the included/excluded items in ns