Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
[3.9] gh-105704: Disallow square brackets ([ and]) in domain names for parsed URLs (GH-129418)#129530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…es for parsed URLs (pythonGH-129418)*pythongh-105704: Disallow square brackets ( and ) in domain names for parsed URLs* Use Sphinx referencesCo-authored-by: Peter Bierma <zintensitydev@gmail.com>* Add mismatched bracket test cases, fix news format* Add more test coverage for ports---------(cherry picked from commitd89a5f6)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
sethmlarson approved these changesJan 31, 2025
This was referencedFeb 3, 2025
YVK49 commentedFeb 10, 2025
Hi, I would like to work on this issue. Could you please assign it to me? Looking forward to contributing! |
There is nothing to do here; we only need to wait for#129509 to be fixed on 3.9 as well. |
ff4e5c2 intopython:3.9 14 checks passed
Uh oh!
There was an error while loading.Please reload this page.
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestApr 9, 2025
…in names for parsed URLs (pythonGH-129418) (python#129530)(cherry picked from commitd89a5f6)Co-authored-by: Seth Michael Larson <seth@python.org>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
This was referencedMay 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CVE-2025-0938] urlparse does not flag hostname *containing* [ or ] as incorrect #105704: Disallow square brackets ( and ) in domain names for parsed URLs
Use Sphinx references
Co-authored-by: Peter Biermazintensitydev@gmail.com
Add mismatched bracket test cases, fix news format
Add more test coverage for ports
(cherry picked from commitd89a5f6)
Co-authored-by: Seth Michael Larsonseth@python.org
Co-authored-by: Peter Biermazintensitydev@gmail.com