Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.10] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171)#129440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…29171)Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the hostaddress or the "any" address, use the local communication address(loopback): VMADDR_CID_LOCAL.On Linux 6.9, apparently, the /dev/vsock device is now available butget_cid() returns VMADDR_CID_ANY (-1).(cherry picked from commit45db419)Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commite94dbe4)(cherry picked from commitc750061)(cherry picked from commitcbfe302)
!buildbot PPC64LE.Fedora.Stable.Refleaks |
bedevere-bot commentedJan 30, 2025
See#129509 for the RtD preview failure. This PR does not touch docs so it should be good to merge. |
If this is merged I recommend also backporting#129561 |
Let's add it here & test them together. |
…python#119465 (python#129561)Restore the skipUnless removed bypython#119465.This test can only pass on virtual machines, not actual machines.actual machines see:``` self.cli.connect((cid, VSOCKPORT)) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^OSError: [Errno 19] No such device```Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
2bd9f9b intopython:3.10 12 of 13 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@miss-islington for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington added a commit to miss-islington/cpython that referenced this pull requestFeb 13, 2025
…29171) (pythonGH-129440)* [3.11]pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-129171)Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the hostaddress or the "any" address, use the local communication address(loopback): VMADDR_CID_LOCAL.On Linux 6.9, apparently, the /dev/vsock device is now available butget_cid() returns VMADDR_CID_ANY (-1).(cherry picked from commit45db419)Co-authored-by: Victor Stinner <vstinner@python.org>(cherry picked from commite94dbe4)(cherry picked from commitc750061)(cherry picked from commitcbfe302)*pythongh-119461: Restore the testSocket VSOCK skipUnless removed by PRpythonGH-119465 (pythonGH-129561)Restore the skipUnless removed bypythonGH-119465.This test can only pass on virtual machines, not actual machines.actual machines see:``` self.cli.connect((cid, VSOCKPORT)) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^OSError: [Errno 19] No such device```Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.---------(cherry picked from commit2bd9f9b)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Gregory P. Smith <greg@krypto.org>
GH-130075 is a backport of this pull request to the3.9 branch. |
ambv pushed a commit that referenced this pull requestFeb 19, 2025
…9440) (#130075)Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the hostaddress or the "any" address, use the local communication address(loopback): VMADDR_CID_LOCAL.On Linux 6.9, apparently, the /dev/vsock device is now available butget_cid() returns VMADDR_CID_ANY (-1).(cherry picked from commit45db419)(cherry picked from commite94dbe4)(cherry picked from commitc750061)(cherry picked from commitcbfe302)---Restore the skipUnless removed byGH-119465.This test can only pass on virtual machines, not actual machines.Actual machines see:``` self.cli.connect((cid, VSOCKPORT)) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^OSError: [Errno 19] No such device```Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.(cherry picked from commit2bd9f9b)Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.
On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).
(cherry picked from commit45db419)
Co-authored-by: Victor Stinnervstinner@python.org
(cherry picked from commite94dbe4)
(cherry picked from commitc750061)
(cherry picked from commitcbfe302)