Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-127146: Skip test_readinto_non_blocking on Emscripten#129421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-127146: Skip test_readinto_non_blocking on Emscripten#129421
Uh oh!
There was an error while loading.Please reload this page.
Conversation
non_blocking doesn't really work on Emscripten
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
7893908
intopython:mainUh oh!
There was an error while loading.Please reload this page.
@hoodmane,@freakboy3742 rather than a platform-specific check for this one test, could you make it so the |
@cmaloney That's definitely an approach that wecould take - it's an approach that iOS and Android use for a bunch of APIs in the "they exist, but you can't call them" category. However, in this case, it's not 100% clear if the issue here is a bug in Emscripten itself. If it is, then a test skip seems more appropriate. If it turns out there is a fundamental limitation that prevents Emscripten from avoiding the problem causing this test failure, then I'd agree guarding the entire feature would make sense. |
Uh oh!
There was an error while loading.Please reload this page.
non_blocking doesn't really work on Emscripten.