Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-129403: Fix ValueError Messages#129419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 3 commits intopython:mainfromStanFromIreland:fix-error-msg
Jan 30, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commentedJan 28, 2025•
edited
Loading

All cases of this have been fixed confirmed by grep

grep -r "parties must be > 0"

@StanFromIreland
Copy link
MemberAuthor

Requesting Review@sobolevn

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's worth adding a blurb for this.

sobolevn reacted with thumbs up emoji
@StanFromIreland
Copy link
MemberAuthor

@ZeroIntensity@sobolevn NEWS added.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Itmight be worth adding anassertRaiseRegex test case, but I'm fine without it.

…14159.rstCo-authored-by: Peter Bierma <zintensitydev@gmail.com>
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this, LGTM.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you! We generally don't backport the error message changes, but these ones were incorrect, so I treat them as bugs, so I will backport these changes.

@sobolevnsobolevn added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsJan 30, 2025
@sobolevnsobolevn merged commitbcb25d6 intopython:mainJan 30, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks@StanFromIreland for the PR, and@sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 30, 2025
…threading.Barrier` (pythonGH-129419)(cherry picked from commitbcb25d6)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

GH-129468 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 30, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 30, 2025
…threading.Barrier` (pythonGH-129419)(cherry picked from commitbcb25d6)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

GH-129469 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 30, 2025
sobolevn pushed a commit that referenced this pull requestJan 30, 2025
…`threading.Barrier` (GH-129419) (#129469)gh-129403: Fix `ValueError` messages in `asyncio.Barrier` and `threading.Barrier` (GH-129419)(cherry picked from commitbcb25d6)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
sobolevn pushed a commit that referenced this pull requestJan 30, 2025
…`threading.Barrier` (GH-129419) (#129468)gh-129403: Fix `ValueError` messages in `asyncio.Barrier` and `threading.Barrier` (GH-129419)(cherry picked from commitbcb25d6)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestFeb 7, 2025
…threading.Barrier` (python#129419)Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland@sobolevn@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp