Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91048: fix thread safety for asyncio stack introspection APIs#129399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 2 commits intopython:mainfromkumaraditya303:tsafe
Feb 6, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commentedJan 28, 2025•
edited
Loading

Changes:

  • Add critical sections where required before calling impl function
  • Add critical section assertions
  • Move getters setters to be together with others
  • Elide away unnecessary type checks and align functions to takeFutureObj * as all the other ones already do. In most cases, we avoid type checking on task which is guaranteed to be task or its subclass.

@kumaraditya303
Copy link
ContributorAuthor

Merging this as its been sitting idle for over a week now.

@kumaraditya303kumaraditya303 merged commit75c5519 intopython:mainFeb 6, 2025
41 checks passed
@kumaraditya303kumaraditya303 deleted the tsafe branchFebruary 6, 2025 16:04
if (TaskOrFuture_Check(state, fut) && TaskOrFuture_Check(state, waiter)) {
int res;
Py_BEGIN_CRITICAL_SECTION(fut);
res = future_awaited_by_add(state, (FutureObj *)fut, waiter);
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, this should have beenfuture_awaited_by_discard, fixing#129731.

I'm surprised that no tests failed, seems like test coverage is less for these functions...

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestFeb 7, 2025
cmaloney pushed a commit to cmaloney/cpython that referenced this pull requestFeb 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@ambvambvAwaiting requested review from ambv

@pablogsalpablogsalAwaiting requested review from pablogsal

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp