Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-129388: Use user supplied env vars when checking for gdbm deps#129389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
erlend-aasland wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromerlend-aasland:better-gdbm-probing

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJan 28, 2025•
edited by bedevere-appbot
Loading

Use GDBM_CFLAGS and GDBM_LIBS for all gdbm related checks.

Use GDBM_CFLAGS and GDBM_LIBS for all gdbm related checks.
Comment on lines +4408 to +4410
dnl check for _dbmmodule.c dependencies
dnl ndbm, gdbm_compat, libdb
AC_CHECK_HEADERS([ndbm.h], [
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we're fine keeping this inside theGDBM_* env flag context, since this check also encompasses GDBM compat.

@erlend-aaslanderlend-aasland added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsJan 28, 2025
@erlend-aasland
Copy link
ContributorAuthor

Hm, the fix is not so straightforward as I thought; I'll have to look more closely at this.

Copy link
Contributor

@zaniebzanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me

@zanieb
Copy link
Contributor

Yeah interested in that CI failure — seems fine otherwise.

@tomasr8tomasr8 removed the needs backport to 3.12only security fixes labelApr 10, 2025
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zaniebzaniebzanieb approved these changes

@corona10corona10Awaiting requested review from corona10corona10 will be requested when the pull request is marked ready for reviewcorona10 is a code owner

Assignees
No one assigned
Labels
awaiting core reviewneeds backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@erlend-aasland@zanieb@serhiy-storchaka@tomasr8
[8]ページ先頭
©2009-2025 Movatter.jp