Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-128690: Use test_embed in PGO profile builds again#129377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
neonene wants to merge1 commit intopython:mainfromneonene:restore_embed
Closed

gh-128690: Use test_embed in PGO profile builds again#129377

neonene wants to merge1 commit intopython:mainfromneonene:restore_embed

Conversation

@neonene
Copy link
Contributor

@neoneneneonene commentedJan 27, 2025
edited by bedevere-appbot
Loading

This reverts the temporal commitb00e125.

The issue withtest_init_pyvenv_cfg failing is closed as resolved.

cc@ned-deily

@vstinner
Copy link
Member

test_embed is slow and mostly spawns sub-processes. I'm not convinced that it's an useful tests to train the PGO build.

cc@pablogsal@corona10@markshannon

@neonene
Copy link
ContributorAuthor

I'd prefer a more explicit announcement iftest_embed will not be used in PGO. Also, I'd prefer older versions (3.10 to 3.13) to have the same conditions.

@vstinner
Copy link
Member

I'd prefer a more explicit announcement if test_embed will not be used in PGO. Also, I'd prefer older versions (3.10 to 3.13) to have the same conditions.

I suggest to also remove test_embed from 3.12 and 3.13 in this case, and document the change in the Build category.

neonene reacted with thumbs up emoji

@neonene
Copy link
ContributorAuthor

neonene commentedFeb 4, 2025
edited
Loading

I suggest to also remove test_embed from 3.12 and 3.13 in this case, and document the change in the Build category.

I have opened#129660.

@neoneneneonene closed thisFeb 4, 2025
@neoneneneonene deleted the restore_embed branchFebruary 5, 2025 15:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neonene@vstinner

[8]ページ先頭

©2009-2025 Movatter.jp