Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-128690: Use test_embed in PGO profile builds again#129377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
test_embed is slow and mostly spawns sub-processes. I'm not convinced that it's an useful tests to train the PGO build. |
I'd prefer a more explicit announcement if |
I suggest to also remove test_embed from 3.12 and 3.13 in this case, and document the change in the Build category. |
neonene commentedFeb 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have opened#129660. |
Uh oh!
There was an error while loading.Please reload this page.
This reverts the temporal commitb00e125.
The issue with
test_init_pyvenv_cfgfailing is closed as resolved.cc@ned-deily
test_embed.test_init_pyvenv_cfg()fails #128690