Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-127146: Update test skips for Emscripten 4.0.1#129375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

hoodmane
Copy link
Contributor

@hoodmanehoodmane commentedJan 27, 2025
edited by bedevere-appbot
Loading

PRemscripten-core/emscripten#23306 fixed stating pipes and will be released as part of Emscripten 4.0.2. I removed skips for various other testes that were fixed in 4.0.1 or earlier.

@bedevere-appbedevere-appbot added awaiting review testsTests in the Lib/test dir labelsJan 27, 2025
@hoodmanehoodmane changed the titleUpdate test skips for Emscripten 4.0.1gh-127146: Update test skips for Emscripten 4.0.1Jan 27, 2025
Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All makes sense; the only issue preventing merge is the RTD build failure... not sure what is going on there. I'll poke around and see what I can find out.

@zware
Copy link
Member

Dumb question, but can the Emscripten version be detected so as to skip based on that version? I think there's prior art for this for various other platforms.

@freakboy3742
Copy link
Contributor

Dumb question, but can the Emscripten version be detected so as to skip based on that version? I think there's prior art for this for various other platforms.

It almost certainly can be; but it will require the analog ofplatform.ios_ver()/platform.mac_ver() (et al) to expose the platform version identity. I imagineplatform.emscripten_ver() (orwasm_ver, if there's an opportunity to share with WASI) will eventually exist; but it doesn't yet.

zware reacted with thumbs up emoji

@freakboy3742freakboy3742enabled auto-merge (squash)January 28, 2025 00:43
@freakboy3742freakboy3742 merged commit8e57877 intopython:mainJan 28, 2025
37 checks passed
@hoodmanehoodmane deleted the emscripten-skips-for-4.0.1 branchJanuary 28, 2025 09:50
@hoodmane
Copy link
ContributorAuthor

We havesys._emscripten_info.emscripten_version. So we could add the following tosupport:

defis_emscripten_lt(ver):ifnotis_emscripten:returnFalsever_tuple=tuple(int(x)forxinver.split("."))returnsys._emscripten_info.emscripten_version<ver_tuple

and then putskipIf(is_emscripten_lt("4.0.1")).

@freakboy3742
Copy link
Contributor

We'll eventually want to surface the version in platform for consistency, rather than the semi-private name on_sys. I'd also suggest using a tuple, rather than parsing the string at runtime,

We could also consider making this a feature ofis_emscripten , so thatskipIf(is_emscripten()) is "skip any version" andskipIf(is_emscripten((4,0,1)) does an additional version check.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@freakboy3742freakboy3742freakboy3742 approved these changes

@brettcannonbrettcannonbrettcannon approved these changes

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@hoodmane@zware@freakboy3742@brettcannon

[8]ページ先頭

©2009-2025 Movatter.jp