Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-129223: Raise KeyError in search_map_for_section() if not found#129262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 2 commits intopython:mainfromvstinner:search_map_for_section
Jan 25, 2025

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedJan 24, 2025•
edited by bedevere-appbot
Loading

@vstinner
Copy link
MemberAuthor

@pablogsal@ambv@encukou: This change fix the SystemError in test_external_inspection on Fedora Stable with LTO.

@ambv
Copy link
Contributor

I'm not crazy about this approach because silently skipping tests when we couldn't find a section on a platform that we expected to be able to find the section is a bug. The fix in#129225 actually addresses the problem, which was the compiler optimizing away debug sections unless__attribute__((used)) was used.

@vstinner
Copy link
MemberAuthor

I can modify my PR to not skip the tests on KeyError.

@pablogsal
Copy link
Member

I can modify my PR to not skip the tests on KeyError.

This should be fixed by the real fix#129225. Please, let's remove the skips because that will be masking actual errors that we want to fix. Let's merge the PR with the new raising of KeyError 👍

@vstinner
Copy link
MemberAuthor

@ambv@pablogsal: Ok, I modified my PR only to fix theSystemError, tests are no longer skipped.

@ambvambv merged commitbe98fda intopython:mainJan 25, 2025
40 checks passed
@vstinnervstinner deleted the search_map_for_section branchJanuary 25, 2025 20:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@vstinnervstinner

Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@ambv@pablogsal
[8]ページ先頭
©2009-2025 Movatter.jp