Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119182: Use public PyUnicodeWriter in _json.c#129249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:json_writer
Jan 24, 2025

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedJan 23, 2025•
edited by bedevere-appbot
Loading

Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API.

Replace the private _PyUnicodeWriter API with the publicPyUnicodeWriter API.
Copy link
Contributor

@cmaloneycmaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Have a plan for_PyUnicodeWriter_IsEmpty?

@vstinner
Copy link
MemberAuthor

Have a plan for _PyUnicodeWriter_IsEmpty?

My plan is to leave it in_json.c for now :-) I would prefer to not make it public, unless more people ask for such feature.

Also, the function can be removed and replaced with anempty variable. I just tried to minimize changes in my PR.

cmaloney reacted with thumbs up emoji

@vstinnervstinner merged commit6e63c47 intopython:mainJan 24, 2025
44 checks passed
@vstinnervstinner deleted the json_writer branchJanuary 24, 2025 10:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cmaloneycmaloneycmaloney approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vstinner@cmaloney
[8]ページ先頭
©2009-2025 Movatter.jp