NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-129231: group executable JIT code in memory#129232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

brandtbucher merged 3 commits intopython:mainfromdiegorusso:jit-layout

Feb 2, 2025

Merged

gh-129231: group executable JIT code in memory#129232

brandtbucher merged 3 commits intopython:mainfromdiegorusso:jit-layout

Feb 2, 2025

Conversation

Copy link

Contributor

diegorusso commentedJan 23, 2025•
edited by bedevere-appbot
Loading

Issue:JIT: lay out memory to group executable code together #129231

pythongh-129231: group executable JIT code in memory

657ce11

diegorusso requested review frombrandtbucher andsavannahostrowski ascode owners

January 23, 2025 17:13

bedevere-appbot added the awaiting review label

Jan 23, 2025

bedevere-appbot mentioned this pull request

Jan 23, 2025

JIT: lay out memory to group executable code together#129231

Closed

Copy link

ContributorAuthor

diegorusso commentedJan 23, 2025•
edited
Loading

The change is not really tested as we need the-fplt flag on AArch64. Without this flag, clang-19 doesn't make use of the trampolines.
This is the branch that makes use of thefplt on AArch64 Linux:https://github.com/diegorusso/cpython/tree/fplt

We really need to get those changes first and then re-test this PR.

diegorusso added the topic-JIT label

Jan 23, 2025

📜🤖 Added by blurb_it.

60168ee

brandtbucher approved these changes

Jan 29, 2025

View reviewed changes

Copy link

Member

brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thanks! I appreciate that you reordered things to reflect the new layout. But I don't think the reordering makes as much sense in theStencilGroup struct, so can you leave that the way it was?