Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add colour to GitHub Actions output#129196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromhugovk:3.14-ci-colour
Jan 22, 2025
Merged

Conversation

hugovk
Copy link
Member

Following the merge of#127223,#127719,#127877,#128498 and#128687, we can now enable colour in theunittest andtest.regrtest output on GitHub Actions usingFORCE_COLOR.

The biggest benefit is it helps us find failures when scrolling the long logs, and usually the reason to open the logs in the first place is to find a failure.

For example, here's a forced failure in another branch:

image

https://github.com/hugovk/cpython/actions/runs/12915439756/job/36017613160

Accessibility check: it's important not to rely on colour alone to confer information, and the current textual output is not changed, and continues to say pass/skip/fail as now. The colour is an addition.

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JIT CI changes look good!

hugovk reacted with rocket emoji
@hugovk
Copy link
MemberAuthor

Thank you flaky test, it was easy to find you and conclude not relevant here, and restart the job :)

image

https://github.com/python/cpython/actions/runs/12916819582/job/36021859818?pr=129196

@hugovkhugovkenabled auto-merge (squash)January 22, 2025 21:13
@hugovk
Copy link
MemberAuthor

unittest andtest.regrtest don't have colour in 3.13 or earlier, but let's backport these to keep the diffs between the files smaller for future backports, and it can enable colour in any other tools on the CI that support it.

@hugovkhugovk added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsJan 22, 2025
@hugovkhugovk merged commit298dda5 intopython:mainJan 22, 2025
62 checks passed
@hugovkhugovk deleted the 3.14-ci-colour branchJanuary 22, 2025 21:22
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 22, 2025
(cherry picked from commit298dda5)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-129198 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 22, 2025
@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 298dda57709c45cbcb44831e0d682dc071af5293 3.12

hugovk added a commit to hugovk/cpython that referenced this pull requestJan 22, 2025
(cherry picked from commit298dda5)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-129199 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 22, 2025
hugovk added a commit that referenced this pull requestJan 22, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

@ezio-melottiezio-melottiezio-melotti approved these changes

@brandtbucherbrandtbucherbrandtbucher approved these changes

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees

@hugovkhugovk

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@hugovk@AA-Turner@ezio-melotti@brandtbucher
[8]ページ先頭
©2009-2025 Movatter.jp