Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-129098: Skip reading source lines if filename is_pyrepl.__main__.py inside REPL#129099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
WolframAlph wants to merge1 commit intopython:mainfromWolframAlph:fix-repl

Conversation

@WolframAlph
Copy link
Contributor

@WolframAlphWolframAlph commentedJan 20, 2025•
edited by bedevere-appbot
Loading

@WolframAlph
Copy link
ContributorAuthor

WolframAlph commentedJan 20, 2025•
edited
Loading

I don't have much context about REPL and not sure this is the correct way to fix this. After spending some time debugging where this comes from, I found out that adding check insidelazycache fixes this issue. Let me know if this is correct way or if this should be done differently.

@WolframAlphWolframAlph changed the titlegh-129098: Skip reading source lines if filename is_pyrepl.__main__ inside REPLgh-129098: Skip reading source lines if filename is_pyrepl.__main__.py inside REPLJan 20, 2025
@picnixz
Copy link
Member

picnixz commentedJan 20, 2025•
edited
Loading

I'm not sure we should do it.linecache is independent of the REPL and we shouldn't rely on such checks (maybe the REPL should have its own linecache or something like that? or maybe we should have some better hooking mechanism for it).

Or we could check whether the reported traceback is correct or not (or we could hookcompile itself?)

AlexWaygood and encukou reacted with thumbs up emoji

@picnixz
Copy link
Member

Let's continue the discussion on the issue itself.

@encukouencukou added the topic-replRelated to the interactive shell labelJan 21, 2025
@WolframAlphWolframAlph marked this pull request as draftJanuary 23, 2025 15:26
@picnixz
Copy link
Member

Closing since it was superseded by#130721.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

topic-replRelated to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WolframAlph@picnixz@encukou
[8]ページ先頭
©2009-2025 Movatter.jp