Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-71339: Use new assertion methods in tests#129046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJan 20, 2025
edited by bedevere-appbot
Loading

They provide better error report.

Only 1-2 lines are changed in the half of files, 3-4 lines in other quarter of files, and only in about 10 files there are more than 10 changed lines. So all this have been united in a single PR.

@serhiy-storchakaserhiy-storchaka added testsTests in the Lib/test dir skip news labelsJan 20, 2025
@picnixz
Copy link
Member

Not sure if it's me or not, but having that many files to review makes my GH interface crash (or load very slowly). Would it be possible to split this PR, at least per folders? just so that 1) it reduces the number of review requests 2) it helps us to review if possible?

@serhiy-storchaka
Copy link
MemberAuthor

I have already already created 15 other PRs for groups of files with significant number of changes. But it is not worth to create a PR for 5 changed lines in 2 files.

picnixz reacted with thumbs up emoji

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@picnixz for commitcc1f37a 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJan 21, 2025
@picnixz
Copy link
Member

(Oh maybe I shouldn't have scheduled build bots if you had other commits... sorry in advance, though I can look at the buildbots status page)

@terryjreedy
Copy link
Member

terryjreedy commentedJan 23, 2025
edited
Loading

I was checking test_idle when I found this PR in my mailbox. (EDIT) 10 rather than just 2 idle tests can be changed and I want to backport them. I think it easiest if I make a separate PR (DONE,#129213) attached to the same issue I copied the 2 changes made here so there should be no conflict.

EDIT The IDLE changes are merged and backported.

@terryjreedy
Copy link
Member

terryjreedy commentedJan 23, 2025
edited by mhsmith
Loading

I non-recursively searchedself.assert.*(issubclass|hasattr|startswith|endswith) inF:\dev\3x\Lib\test\test_t*.py (with IDLE) and found the same change candidates in thetest_t*.py files included here (and only a couple of false positives). The replacements all looked right.

This is the 1 AMD64 Android failure.

======================================================================FAIL: testAssertHasAttr (test.test_unittest.test_case.Test_TestCase.testAssertHasAttr)----------------------------------------------------------------------Traceback (most recent call last):  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_unittest/test_case.py", line 803, in testAssertHasAttr    with self.assertRaises(self.failureException) as cm:         ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^AssertionError: AssertionError not raised

@serhiy-storchaka
Copy link
MemberAuthor

The patch was initially created in 2016. It was then updated few years later, and just before creating this PR. Since the IDLE tests are located outside of theLib/test tree, I missed new tests there.

@mhsmith
Copy link
Member

!buildbot ios

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@mhsmith for commitcc1f37a 🤖

The command will test the builders whose names match following regular expression:ios

The builders matched are:

  • iOS ARM64 Simulator PR

@mhsmith
Copy link
Member

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@mhsmith for commitcc1f37a 🤖

The command will test the builders whose names match following regular expression:android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@mhsmith
Copy link
Member

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@mhsmith for commitcc1f37a 🤖

The command will test the builders whose names match following regular expression:android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@mhsmith
Copy link
Member

Not sure what happened before with Android and iOS, but they both seem fine now.

@serhiy-storchaka
Copy link
MemberAuthor

It was an issue in different tests which was fixed by#129133.

No need to trigger buildbots. This PR is not emergent. It will be merged after merging all related PRs. Some changes can be extracted into separate PRs (like IDLE's).

mhsmith reacted with thumbs up emoji

@kumaraditya303kumaraditya303 removed their request for reviewFebruary 21, 2025 18:16
@brettcannonbrettcannon removed their request for reviewApril 14, 2025 17:01
@serhiy-storchaka
Copy link
MemberAuthor

There have been practically no conflicts in the last few months. This means that this PR affects a very small part of the code that is actively changing. So I plan to merge this PR without backporting to 3.13. Probability of conflicts in future backports to 3.13 is low.

@serhiy-storchakaserhiy-storchaka merged commit2602d8a intopython:mainMay 22, 2025
38 checks passed
@serhiy-storchakaserhiy-storchaka deleted the use-extra-assertions branchMay 22, 2025 10:17
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 22, 2025
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2025
(cherry picked from commit2602d8a)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-134498 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 22, 2025
serhiy-storchaka added a commit that referenced this pull requestMay 22, 2025
…34498)(cherry picked from commit2602d8a)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@picnixzpicnixzpicnixz approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@barneygalebarneygaleAwaiting requested review from barneygalebarneygale is a code owner

@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

@terryjreedyterryjreedyAwaiting requested review from terryjreedy

@ericvsmithericvsmithAwaiting requested review from ericvsmithericvsmith is a code owner

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@Eclips4Eclips4Awaiting requested review from Eclips4Eclips4 is a code owner

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

@tirantiranAwaiting requested review from tirantiran is a code owner

@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@serhiy-storchaka@picnixz@erlend-aasland@bedevere-bot@terryjreedy@mhsmith@JelleZijlstra

[8]ページ先頭

©2009-2025 Movatter.jp