Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-71339: Use new assertion methods in tests#129046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-71339: Use new assertion methods in tests#129046
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Not sure if it's me or not, but having that many files to review makes my GH interface crash (or load very slowly). Would it be possible to split this PR, at least per folders? just so that 1) it reduces the number of review requests 2) it helps us to review if possible? |
I have already already created 15 other PRs for groups of files with significant number of changes. But it is not worth to create a PR for 5 changed lines in 2 files. |
bedevere-bot commentedJan 21, 2025
(Oh maybe I shouldn't have scheduled build bots if you had other commits... sorry in advance, though I can look at the buildbots status page) |
terryjreedy commentedJan 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I was checking test_idle when I found this PR in my mailbox. (EDIT) 10 rather than just 2 idle tests can be changed and I want to backport them. I think it easiest if I make a separate PR (DONE,#129213) attached to the same issue I copied the 2 changes made here so there should be no conflict. EDIT The IDLE changes are merged and backported. |
terryjreedy commentedJan 23, 2025 • edited by mhsmith
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by mhsmith
Uh oh!
There was an error while loading.Please reload this page.
I non-recursively searched This is the 1 AMD64 Android failure.
|
The patch was initially created in 2016. It was then updated few years later, and just before creating this PR. Since the IDLE tests are located outside of the |
!buildbot ios |
bedevere-bot commentedJan 23, 2025
!buildbot android |
bedevere-bot commentedJan 23, 2025
!buildbot android |
bedevere-bot commentedJan 23, 2025
Not sure what happened before with Android and iOS, but they both seem fine now. |
It was an issue in different tests which was fixed by#129133. No need to trigger buildbots. This PR is not emergent. It will be merged after merging all related PRs. Some changes can be extracted into separate PRs (like IDLE's). |
There have been practically no conflicts in the last few months. This means that this PR affects a very small part of the code that is actively changing. So I plan to merge this PR without backporting to 3.13. Probability of conflicts in future backports to 3.13 is low. |
2602d8a
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit2602d8a)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-134498 is a backport of this pull request to the3.14 branch. |
Uh oh!
There was an error while loading.Please reload this page.
They provide better error report.
Only 1-2 lines are changed in the half of files, 3-4 lines in other quarter of files, and only in about 10 files there are more than 10 changed lines. So all this have been united in a single PR.