Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
[3.12] gh-128679: Fix tracemalloc.stop() race conditions (#128897)#129022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…n#128897)tracemalloc_alloc(), tracemalloc_realloc(), PyTraceMalloc_Track(),PyTraceMalloc_Untrack() and _PyTraceMalloc_TraceRef() now checktracemalloc_config.tracing after calling TABLES_LOCK()._PyTraceMalloc_Stop() now protects more code with TABLES_LOCK(),especially setting tracemalloc_config.tracing to 1.Add a test using PyTraceMalloc_Track() to test tracemalloc.stop()race condition.Call _PyTraceMalloc_Init() at Python startup.(cherry picked from commit6b47499)
This was referencedJan 19, 2025
I tested manually my change on FreeBSD with Python built in release mode. I ran test_tracemalloc_track_race() 1,000x in a loop (using |
6df22cb intopython:3.12 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
tracemalloc_alloc(), tracemalloc_realloc(), PyTraceMalloc_Track(), PyTraceMalloc_Untrack() and _PyTraceMalloc_TraceRef() now check tracemalloc_config.tracing after calling TABLES_LOCK().
_PyTraceMalloc_Stop() now protects more code with TABLES_LOCK(), especially setting tracemalloc_config.tracing to 1.
Add a test using PyTraceMalloc_Track() to test tracemalloc.stop() race condition.
Call _PyTraceMalloc_Init() at Python startup.
(cherry picked from commit6b47499)