Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-128520: Makepathlib._abc.WritablePath
a sibling ofReadablePath
#129014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…blePath`In the private pathlib ABCs, support write-only virtual filesystems bymaking `WritablePath` inherit directly from `JoinablePath`, rather thansubclassing `ReadablePath`.There are two complications:- `ReadablePath.open()` applies to both reading and writing- `ReadablePath.copy` is secretly an object that supports the *read* side of copying, whereas `WritablePath.copy` is a different kind of object supporting the *write* sideWe untangle these as follow:- A new `pathlib._abc.magic_open()` function replaces the `open()` method, which is dropped from the ABCs but remains in `pathlib.Path`. The function works like `io.open()`, but additionally accepts objects with `__open_rb__()` or `__open_wb__()` methods as appropriate for the mode. These new dunders are made abstract methods of `ReadablePath` and `WritablePath` respectively. If the pathlib ABCs are made public, we could consider blessing an "openable" protocol and supporting it in `io.open()`, removing the need for `pathlib._abc.magic_open()`.- `ReadablePath.copy` becomes a true method, whereas `WritablePath.copy` is deleted. A new `ReadablePath._copy_reader` property provides a `CopyReader` object, and similarly `WritablePath._copy_writer` is a `CopyWriter` object. OncepythonGH-125413 is resolved, we'll be able to move the `CopyReader` functionality into `ReadablePath.info` and eliminate `ReadablePath._copy_reader`.
17 tasks
01d9150
intopython:main 37 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In the private pathlib ABCs, support write-only virtual filesystems by making
WritablePath
inherit directly fromJoinablePath
, rather than subclassingReadablePath
. There are two complications:Problem 1:
ReadablePath.open()
applies to both reading and writingSolution: a new
pathlib._abc.magic_open()
function replaces theopen()
method, which is dropped from the ABCs but remains inpathlib.Path
. The function works likeio.open()
, but additionally accepts objects with__open_rb__()
or__open_wb__()
methods as appropriate for the mode. These new dunders are made abstract methods ofReadablePath
andWritablePath
respectively. If the pathlib ABCs are made public, we could consider blessing an "openable" protocol and supporting it inio.open()
, removing the need forpathlib._abc.magic_open()
.Problem 2:
ReadablePath.copy
is secretly an object that supports theread side of copying, whereasWritablePath.copy
is a subclass additionally supporting thewrite sideSolution:
ReadablePath.copy
becomes a true method, whereasWritablePath.copy
is deleted. A newReadablePath._copy_reader
property provides aCopyReader
object, and similarlyWritablePath._copy_writer
is aCopyWriter
object. OnceGH-125413 is resolved, we'll be able to move theCopyReader
functionality intoReadablePath.info
and eliminateReadablePath._copy_reader
.