Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-129011: Update comments in FileIO to match current code#129012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
11 commits Select commitHold shift + click to select a range
59c763e
Update comments in FileIO to match current code
cmaloney9b714f2
Regenerate clinic
cmaloneyabe4436
Update Modules/_io/fileio.c
cmaloneyb0f3afe
Regenerate clinic
cmaloney270974f
Merge remote-tracking branch 'upstream/main' into fileio_comments
cmaloney514dad3
Update _pyio docs to match _io
cmaloney3f4605b
Merge branch 'main' into fileio_comments
cmaloney28c63ce
Merge branch 'main' into fileio_comments
cmaloney600f064
Apply suggestions from code review
hauntsaninja82d6f17
make regen-clinic
cmaloney74abf36
Refer to FileIO not _io.FileIO, also get build to re-run
cmaloneyFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Update _pyio docs to match _io
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit514dad31364986564819fa36e9a732b7f94e12b6
There are no files selected for viewing
17 changes: 14 additions & 3 deletionsLib/_pyio.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1636,7 +1636,13 @@ def _checkWritable(self, msg=None): | ||
def read(self, size=None): | ||
"""Read at most size bytes, returned as bytes. | ||
If size is less than 0, read all bytes in the file making | ||
multiple read calls. See ``_io.FileIO.readall``. | ||
Attempts to make only one system call, retrying only per | ||
PEP-475 (EINTR). This means less data may be returned than | ||
hauntsaninja marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
requested. | ||
In non-blocking mode, returns None if no data is available. | ||
Return an empty bytes object at EOF. | ||
""" | ||
@@ -1652,8 +1658,13 @@ def read(self, size=None): | ||
def readall(self): | ||
"""Read all data from the file, returned as bytes. | ||
Reads until either there is an error or read() returns size 0 | ||
(indicates EOF). If the file is already at EOF, returns an | ||
empty bytes object. | ||
In non-blocking mode, returns as much data as could be read | ||
before EAGAIN. If no data is available (EAGAIN is returned | ||
before bytes are read) returns None. | ||
""" | ||
self._checkClosed() | ||
self._checkReadable() | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.